Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 8772022: Flush stdout when printing perf values for ChromeOS in pyauto perf tests. (Closed)

Created:
9 years ago by dennis_jeffrey
Modified:
9 years ago
Reviewers:
Nirnimesh
CC:
chromium-reviews, Nirnimesh, John Grabowski, anantha, dyu1, Paweł Hajdan Jr., dennis_jeffrey
Visibility:
Public.

Description

Flush stdout when printing perf values for ChromeOS in pyauto perf tests. The pyauto-based perf tests output perf results in a special format, which are extracted from stdout and stored for graphing purposes. I encountered a case where one of these specially-formatted perf output lines was broken up by other, interleaved output, causing the perf value to be missed when the output was parsed to search for perf values. I believe that flushing stdout immediately after printing each perf output line should fix this problem. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112744

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/test/functional/perf.py View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
dennis_jeffrey
9 years ago (2011-12-01 22:43:50 UTC) #1
Nirnimesh
9 years ago (2011-12-02 18:00:07 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698