Chromium Code Reviews Chromium Code Reviews
Issue 8772016:
Refactor the gypi files to eliminate some redundancy. (Closed)
Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/| Index: bin/bin.gypi |
| =================================================================== |
| --- bin/bin.gypi (revision 1990) |
| +++ bin/bin.gypi (working copy) |
| @@ -75,46 +75,13 @@ |
| 'sources': [ |
| 'builtin_natives.cc', |
| 'builtin.h', |
| - 'dartutils.h', |
| - 'dartutils.cc', |
| - 'directory.h', |
| - 'directory.cc', |
| - 'directory_posix.cc', |
| - 'directory_win.cc', |
| - 'eventhandler.cc', |
| - 'eventhandler.h', |
| - 'eventhandler_linux.cc', |
| - 'eventhandler_linux.h', |
| - 'eventhandler_macos.cc', |
| - 'eventhandler_macos.h', |
| - 'eventhandler_win.cc', |
| - 'eventhandler_win.h', |
| - 'file.cc', |
| - 'file.h', |
| - 'file_linux.cc', |
| - 'file_macos.cc', |
| - 'file_win.cc', |
| - 'fdutils.h', |
| - 'fdutils_linux.cc', |
| - 'fdutils_macos.cc', |
| - 'globals.h', |
| - 'platform.cc', |
| - 'platform.h', |
| - 'platform_linux.cc', |
| - 'platform_macos.cc', |
| - 'platform_win.cc', |
| - 'process.cc', |
| - 'process.h', |
| - 'process_linux.cc', |
| - 'process_macos.cc', |
| - 'process_win.cc', |
| - 'socket.cc', |
| - 'socket.h', |
| - 'socket_linux.cc', |
| - 'socket_macos.cc', |
| - 'socket_win.cc', |
| - 'set.h', |
| ], |
| + 'includes': [ |
| + 'bin_sources.gypi', |
|
Ivan Posva
2011/12/01 22:19:31
builtin_sources.gypi? bin_sources I would expect t
siva
2011/12/01 23:03:25
Done.
|
| + ], |
| + 'sources/': [ |
| + ['exclude', '_test\\.(cc|h)$'], |
| + ], |
| 'conditions': [ |
| ['OS=="win"', {'sources/' : [ |
| ['exclude', 'fdutils.h'], |
| @@ -139,31 +106,6 @@ |
| ], |
| }, |
| { |
| - # Completely statically linked dart binary. |
| - 'target_name': 'dart_no_snapshot', |
| - 'type': 'executable', |
| - 'dependencies': [ |
| - 'libdart_withcore', |
| - 'libdart_builtin', |
| - ], |
| - 'include_dirs': [ |
| - '..', |
| - ], |
| - 'sources': [ |
| - 'main.cc', |
| - 'snapshot_empty.cc', |
| - 'builtin.cc', |
| - # Include generated source files. |
| - '<(builtin_cc_file)', |
| - ], |
| - 'conditions': [ |
| - ['OS=="win"', { |
| - 'link_settings': { |
| - 'libraries': [ '-lws2_32.lib', '-lRpcrt4.lib' ], |
| - }, |
| - }]], |
| - }, |
| - { |
| # Completely statically linked binary for generating snapshots. |
| 'target_name': 'gen_snapshot', |
| 'type': 'executable', |
| @@ -257,6 +199,7 @@ |
| 'type': 'executable', |
| 'dependencies': [ |
| 'libdart_withcore', |
| + 'libdart_builtin', |
| 'generate_snapshot_test_dat_file', |
| ], |
| 'include_dirs': [ |
| @@ -265,48 +208,9 @@ |
| ], |
| 'sources': [ |
| 'run_vm_tests.cc', |
| - 'dartutils.h', |
| - 'dartutils.cc', |
| - 'directory.h', |
| - 'directory.cc', |
| - 'directory_posix.cc', |
| - 'directory_win.cc', |
| - 'eventhandler.cc', |
| - 'eventhandler.h', |
| - 'eventhandler_linux.cc', |
| - 'eventhandler_linux.h', |
| - 'eventhandler_macos.cc', |
| - 'eventhandler_macos.h', |
| - 'eventhandler_win.cc', |
| - 'eventhandler_win.h', |
| - 'file.cc', |
| - 'file.h', |
| - 'file_test.cc', |
| - 'file_linux.cc', |
| - 'file_macos.cc', |
| - 'file_win.cc', |
| - 'fdutils.h', |
| - 'fdutils_linux.cc', |
| - 'fdutils_macos.cc', |
| - 'platform.cc', |
| - 'platform.h', |
| - 'platform_linux.cc', |
| - 'platform_macos.cc', |
| - 'platform_win.cc', |
| - 'process.cc', |
| - 'process.h', |
| - 'process_linux.cc', |
| - 'process_macos.cc', |
| - 'process_win.cc', |
| - 'socket.cc', |
| - 'socket.h', |
| - 'socket_linux.cc', |
| - 'socket_macos.cc', |
| - 'socket_win.cc', |
| - 'set.h', |
| - 'set_test.cc', |
| ], |
| 'includes': [ |
| + 'bin_sources.gypi', |
| '../vm/vm_sources.gypi', |
| ], |
| 'defines': [ |
| @@ -317,56 +221,8 @@ |
| ['exclude', '\\.(cc|h)$'], |
| ['include', '_test\\.(cc|h)$'], |
| ['include', 'run_vm_tests.cc'], |
| - ['include', 'dart_api_impl.cc'], |
|
Ivan Posva
2011/12/01 22:19:31
Great cleanup!
|
| - ['include', 'dartutils.h'], |
| - ['include', 'dartutils.cc'], |
| - ['include', 'directory.h'], |
| - ['include', 'directory.cc'], |
| - ['include', 'eventhandler.cc'], |
| - ['include', 'eventhandler.h'], |
| - ['include', 'file.cc'], |
| - ['include', 'file.h'], |
| - ['include', 'file_test.cc'], |
| - ['include', 'platform.cc'], |
| - ['include', 'platform.h'], |
| - ['include', 'process.cc'], |
| - ['include', 'process.h'], |
| - ['include', 'socket.cc'], |
| - ['include', 'socket.h'], |
| - ['include', 'set_test.cc'], |
| ], |
| 'conditions': [ |
| - ['OS=="linux"', {'sources/' : [ |
| - ['include', 'directory_posix.cc'], |
| - ['include', 'eventhandler_linux.cc'], |
| - ['include', 'eventhandler_linux.h'], |
| - ['include', 'fdutils.h'], |
| - ['include', 'fdutils_linux.cc'], |
| - ['include', 'file_linux.cc'], |
| - ['include', 'platform_linux.cc'], |
| - ['include', 'process_linux.cc'], |
| - ['include', 'socket_linux.cc'], |
| - ]}], |
| - ['OS=="mac"', {'sources/' : [ |
| - ['include', 'directory_posix.cc'], |
| - ['include', 'eventhandler_macos.cc'], |
| - ['include', 'eventhandler_macos.h'], |
| - ['include', 'fdutils.h'], |
| - ['include', 'fdutils_macos.cc'], |
| - ['include', 'file_macos.cc'], |
| - ['include', 'platform_macos.cc'], |
| - ['include', 'process_macos.cc'], |
| - ['include', 'socket_macos.cc'], |
| - ]}], |
| - ['OS=="win"', {'sources/' : [ |
| - ['include', 'directory_win.cc'], |
| - ['include', 'eventhandler_win.cc'], |
| - ['include', 'eventhandler_win.h'], |
| - ['include', 'file_win.cc'], |
| - ['include', 'platform_win.cc'], |
| - ['include', 'process_win.cc'], |
| - ['include', 'socket_win.cc'], |
| - ]}], |
| ['OS=="win"', { |
| 'link_settings': { |
| 'libraries': [ '-lws2_32.lib', '-lRpcrt4.lib' ], |
