Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Unified Diff: runtime/vm/class_finalizer.h

Issue 8772009: Address Regis' comments, replace AbstractType with Type where possible. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: '' Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/class_finalizer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/class_finalizer.h
===================================================================
--- runtime/vm/class_finalizer.h (revision 1991)
+++ runtime/vm/class_finalizer.h (working copy)
@@ -15,8 +15,10 @@
class Function;
class RawAbstractType;
class RawClass;
+class RawType;
class Script;
class String;
+class Type;
class TypeArguments;
class UnresolvedClass;
@@ -41,8 +43,7 @@
// Finalize and canonicalize type while parsing.
// Set the error message on failure (to String::null() if no error).
- static RawAbstractType* FinalizeAndCanonicalizeType(
- const AbstractType& type, String* errmsg);
+ static RawType* FinalizeAndCanonicalizeType(const Type& type, String* errmsg);
// Pending classes are classes that need to be finalized.
static void AddPendingClasses(const GrowableArray<const Class*>& classes);
@@ -78,8 +79,7 @@
GrowableArray<const Class*>* visited);
static void FinalizeTypeArguments(const Class& cls,
const TypeArguments& arguments);
- static RawAbstractType* ResolveType(
- const Class& cls, const AbstractType& type);
+ static void ResolveType(const Class& cls, const AbstractType& type);
static RawAbstractType* FinalizeType(const AbstractType& type);
static void ResolveAndFinalizeUpperBounds(const Class& cls);
static void VerifyUpperBounds(const Class& cls,
« no previous file with comments | « no previous file | runtime/vm/class_finalizer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698