Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Side by Side Diff: runtime/vm/raw_object.h

Issue 8772009: Address Regis' comments, replace AbstractType with Type where possible. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: '' Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« runtime/vm/parser.cc ('K') | « runtime/vm/parser.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #ifndef VM_RAW_OBJECT_H_ 5 #ifndef VM_RAW_OBJECT_H_
6 #define VM_RAW_OBJECT_H_ 6 #define VM_RAW_OBJECT_H_
7 7
8 #include "vm/assert.h" 8 #include "vm/assert.h"
9 #include "vm/globals.h" 9 #include "vm/globals.h"
10 #include "vm/snapshot.h" 10 #include "vm/snapshot.h"
(...skipping 204 matching lines...) Expand 10 before | Expand all | Expand 10 after
215 kFinalized, // All checks completed, class ready for use. 215 kFinalized, // All checks completed, class ready for use.
216 }; 216 };
217 217
218 private: 218 private:
219 RAW_HEAP_OBJECT_IMPLEMENTATION(Class); 219 RAW_HEAP_OBJECT_IMPLEMENTATION(Class);
220 220
221 RawObject** from() { return reinterpret_cast<RawObject**>(&ptr()->name_); } 221 RawObject** from() { return reinterpret_cast<RawObject**>(&ptr()->name_); }
222 RawString* name_; 222 RawString* name_;
223 RawArray* functions_; 223 RawArray* functions_;
224 RawArray* fields_; 224 RawArray* fields_;
225 RawArray* interfaces_; // Array of AbstractType. 225 RawArray* interfaces_; // Array of AbstractType.
regis 2011/12/01 19:20:43 TODO: RawTypeArguments* interfaces_; // Array of
srdjan 2011/12/01 20:04:09 Done.
226 RawScript* script_; 226 RawScript* script_;
227 RawLibrary* library_; 227 RawLibrary* library_;
228 RawArray* type_parameters_; // Array of String. 228 RawArray* type_parameters_; // Array of String.
229 RawTypeArray* type_parameter_extends_; // DynamicType if no extends clause. 229 RawTypeArray* type_parameter_extends_; // DynamicType if no extends clause.
230 RawAbstractType* super_type_; 230 RawType* super_type_;
231 RawObject* factory_class_; // UnresolvedClass (until finalization) or Class. 231 RawObject* factory_class_; // UnresolvedClass (until finalization) or Class.
232 RawFunction* signature_function_; // Associated function for signature class. 232 RawFunction* signature_function_; // Associated function for signature class.
233 RawArray* functions_cache_; // See class FunctionsCache. 233 RawArray* functions_cache_; // See class FunctionsCache.
234 RawArray* constants_; // Canonicalized values of this class. 234 RawArray* constants_; // Canonicalized values of this class.
235 RawArray* canonical_types_; // Canonicalized types of this class. 235 RawArray* canonical_types_; // Canonicalized types of this class.
regis 2011/12/01 19:20:43 TODO: RawTypeArguments* canonical_types_; // Cano
srdjan 2011/12/01 20:04:09 Done.
236 RawCode* allocation_stub_; // Stub code for allocation of instances. 236 RawCode* allocation_stub_; // Stub code for allocation of instances.
237 RawObject** to() { 237 RawObject** to() {
238 return reinterpret_cast<RawObject**>(&ptr()->allocation_stub_); 238 return reinterpret_cast<RawObject**>(&ptr()->allocation_stub_);
239 } 239 }
240 240
241 cpp_vtable handle_vtable_; 241 cpp_vtable handle_vtable_;
242 intptr_t instance_size_; 242 intptr_t instance_size_;
243 ObjectKind instance_kind_; 243 ObjectKind instance_kind_;
244 intptr_t type_arguments_instance_field_offset_; // May be kNoTypeArguments. 244 intptr_t type_arguments_instance_field_offset_; // May be kNoTypeArguments.
245 intptr_t next_field_offset_; // Offset of then next instance field. 245 intptr_t next_field_offset_; // Offset of then next instance field.
(...skipping 606 matching lines...) Expand 10 before | Expand all | Expand 10 after
852 intptr_t type_; // Uninitialized, simple or complex. 852 intptr_t type_; // Uninitialized, simple or complex.
853 intptr_t flags_; // Represents global/local, case insensitive, multiline. 853 intptr_t flags_; // Represents global/local, case insensitive, multiline.
854 854
855 // Variable length data follows here. 855 // Variable length data follows here.
856 uint8_t data_[0]; 856 uint8_t data_[0];
857 }; 857 };
858 858
859 } // namespace dart 859 } // namespace dart
860 860
861 #endif // VM_RAW_OBJECT_H_ 861 #endif // VM_RAW_OBJECT_H_
OLDNEW
« runtime/vm/parser.cc ('K') | « runtime/vm/parser.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698