webkit/plugins/ppapi/ppb_websocket_impl.h - Issue 8772001: WebSocket Pepper API: error handling improvement

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/plugins/ppapi/ppb_websocket_impl.h

Issue 8772001: WebSocket Pepper API: error handling improvement (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase to remote/master Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webkit/plugins/ppapi/ppb_websocket_impl.h

diff --git a/webkit/plugins/ppapi/ppb_websocket_impl.h b/webkit/plugins/ppapi/ppb_websocket_impl.h

index ddd3482b77500a6c7a1e1e1ac0775733d0b2d6c8..7ac9acd0c59c371cfc205970302ad490fd7ed7fb 100644

--- a/webkit/plugins/ppapi/ppb_websocket_impl.h

+++ b/webkit/plugins/ppapi/ppb_websocket_impl.h

@@ -66,7 +66,7 @@ class PPB_WebSocket_Impl : public ::ppapi::Resource,

virtual void didReceiveMessageError();

virtual void didUpdateBufferedAmount(unsigned long buffered_amount);

virtual void didStartClosingHandshake();

- virtual void didClose(unsigned long buffered_amount,

+ virtual void didClose(unsigned long unhandled_buffered_amount,

ClosingHandshakeCompletionStatus status,

unsigned short code,

const WebKit::WebString& reason);

@@ -75,6 +75,7 @@ class PPB_WebSocket_Impl : public ::ppapi::Resource,

scoped_ptr<WebKit::WebSocket> websocket_;

PP_WebSocketReadyState_Dev state_;

+ bool error_was_received_;

PP_CompletionCallback connect_callback_;

« no previous file with comments | « ppapi/thunk/ppb_websocket_thunk.cc ('k') | webkit/plugins/ppapi/ppb_websocket_impl.cc » ('j') | no next file with comments »