ppapi/tests/test_websocket.cc - Issue 8772001: WebSocket Pepper API: error handling improvement

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ppapi/tests/test_websocket.cc

Issue 8772001: WebSocket Pepper API: error handling improvement (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase to remote/master Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« no previous file with comments | « no previous file | ppapi/thunk/ppb_websocket_thunk.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "ppapi/tests/test_websocket.h"	5 #include "ppapi/tests/test_websocket.h"

6	6

7 #include <string.h>	7 #include <string.h>

8	8

9 #include "ppapi/c/dev/ppb_websocket_dev.h"	9 #include "ppapi/c/dev/ppb_websocket_dev.h"

10 #include "ppapi/c/pp_errors.h"	10 #include "ppapi/c/pp_errors.h"

(...skipping 218 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
229 ReleaseVar(received_message);	229 ReleaseVar(received_message);

230 core_interface_->ReleaseResource(ws);	230 core_interface_->ReleaseResource(ws);

231	231

232 PASS();	232 PASS();

233 }	233 }

234	234

235 // TODO(toyoshim): Add tests for GetBufferedAmount().	235 // TODO(toyoshim): Add tests for GetBufferedAmount().

236 // For now, the function doesn't work fine because update callback in WebKit is	236 // For now, the function doesn't work fine because update callback in WebKit is

237 // not landed yet.	237 // not landed yet.

238	238

	239 // TODO(toyoshim): Add tests for didReceiveMessageError().

	240

239 // TODO(toyoshim): Add other function tests.	241 // TODO(toyoshim): Add other function tests.

OLD	NEW