ppapi/tests/test_websocket.cc - Issue 8772001: WebSocket Pepper API: error handling improvement

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ppapi/tests/test_websocket.cc

Issue 8772001: WebSocket Pepper API: error handling improvement (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: for review Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "ppapi/tests/test_websocket.h"	5 #include "ppapi/tests/test_websocket.h"

6	6

7 #include <string.h>	7 #include <string.h>

8	8

9 #include "base/logging.h"	9 #include "base/logging.h"

10 #include "ppapi/c/dev/ppb_websocket_dev.h"	10 #include "ppapi/c/dev/ppb_websocket_dev.h"

(...skipping 220 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
231 ReleaseVar(received_message);	231 ReleaseVar(received_message);

232 core_interface_->ReleaseResource(ws);	232 core_interface_->ReleaseResource(ws);

233	233

234 PASS();	234 PASS();

235 }	235 }

236	236

237 // TODO(toyoshim): Add tests for GetBufferedAmount().	237 // TODO(toyoshim): Add tests for GetBufferedAmount().

238 // For now, the function doesn't work fine because update callback in WebKit is	238 // For now, the function doesn't work fine because update callback in WebKit is

239 // not landed yet.	239 // not landed yet.

240	240

	241 // TODO(toyoshim): Add tests for didReceiveMessageError().

	242

241 // TODO(toyoshim): Add other function tests.	243 // TODO(toyoshim): Add other function tests.

OLD	NEW