Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8771064: Fixes to (formerly) crashing test ProfileSyncServiceAutofillTest.ServerChangeRace (Closed)

Created:
9 years ago by GeorgeY
Modified:
9 years ago
Reviewers:
Nicolas Zea
CC:
chromium-reviews, Raghu Simha, ncarter (slow), akalin, tim (not reviewing), Paweł Hajdan Jr.
Visibility:
Public.

Description

Fixes to (formerly) crashing test ProfileSyncServiceAutofillTest.ServerChangeRace TEST=ProfileSyncServiceAutofillTest.ServerChangeRace should not crash BUG=57884 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113347

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -5 lines) Patch
M chrome/browser/sync/profile_sync_service_autofill_unittest.cc View 1 2 3 chunks +14 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
GeorgeY
Run this test with --gtest_repeat=100, all 100 succeeded :)
9 years ago (2011-12-07 00:44:24 UTC) #1
Nicolas Zea
LGTM with a nit http://codereview.chromium.org/8771064/diff/2002/chrome/browser/sync/profile_sync_service_autofill_unittest.cc File chrome/browser/sync/profile_sync_service_autofill_unittest.cc (right): http://codereview.chromium.org/8771064/diff/2002/chrome/browser/sync/profile_sync_service_autofill_unittest.cc#newcode27 chrome/browser/sync/profile_sync_service_autofill_unittest.cc:27: #include "chrome/browser/history/history.h" can you just ...
9 years ago (2011-12-07 00:46:42 UTC) #2
GeorgeY
http://codereview.chromium.org/8771064/diff/2002/chrome/browser/sync/profile_sync_service_autofill_unittest.cc File chrome/browser/sync/profile_sync_service_autofill_unittest.cc (right): http://codereview.chromium.org/8771064/diff/2002/chrome/browser/sync/profile_sync_service_autofill_unittest.cc#newcode27 chrome/browser/sync/profile_sync_service_autofill_unittest.cc:27: #include "chrome/browser/history/history.h" On 2011/12/07 00:46:43, nzea wrote: > can ...
9 years ago (2011-12-07 00:55:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/georgey@chromium.org/8771064/3002
9 years ago (2011-12-07 01:02:35 UTC) #4
commit-bot: I haz the power
9 years ago (2011-12-07 05:00:14 UTC) #5 
Change committed as 113347

Powered by Google App Engine
This is Rietveld 408576698