Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 8771063: GTK: Use the correct IDR constant to fix the about box. (Closed)

Created:
9 years ago by Elliot Glaysher
Modified:
9 years ago
Reviewers:
Evan Stade
CC:
chromium-reviews, Dan Beam
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

GTK: Use the correct IDR constant to fix the about box. BUG=106617, 106060 TEST=none

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/ui/gtk/about_chrome_dialog.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Elliot Glaysher
estade: review dbeam: fyi
9 years ago (2011-12-07 00:36:27 UTC) #1
Elliot Glaysher
estade: review
9 years ago (2011-12-07 00:45:46 UTC) #2
Evan Stade
lgtm
9 years ago (2011-12-07 00:46:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/8771063/1
9 years ago (2011-12-07 00:50:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/8771063/1
9 years ago (2011-12-07 02:52:09 UTC) #5
commit-bot: I haz the power
9 years ago (2011-12-07 02:52:10 UTC) #6
Can't apply patch for file chrome/browser/ui/gtk/about_chrome_dialog.cc.
While running patch -p1 --forward --force;
patching file chrome/browser/ui/gtk/about_chrome_dialog.cc
Hunk #1 FAILED at 87.
1 out of 1 hunk FAILED -- saving rejects to file
chrome/browser/ui/gtk/about_chrome_dialog.cc.rej

Powered by Google App Engine
This is Rietveld 408576698