ntp: adjust top padding

ntp: adjust top padding

re-adjusted the padding above the tile grid to have a minimum of 60px rather than 100px, also it scales upwards faster as the page height increases because instead of aligning the middle of the tile grid at 1/3 from the top of the page, we align the 1/3 mark of the tile grid with the 1/3 mark of the page.

the end result is that a browser window <800px tall with 3 rows of apps and a floating bbar still will not have a scrollbar

BUG=101290
TEST=manual


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113345

[Evan Stade, 2011-12-07 00:12:03]

http://codereview.chromium.org/8771060/diff/1/chrome/browser/resources/ntp4/t...
File chrome/browser/resources/ntp4/tile_page.js (left):

http://codereview.chromium.org/8771060/diff/1/chrome/browser/resources/ntp4/t...
chrome/browser/resources/ntp4/tile_page.js:902: usedHeight / 2 - 100 -
this.content_.offsetTop;
I can't remember why I ever put offsetTop in here, but it appears to always be 0
now, so no need to subtract it off.

[Dan Beam, 2011-12-07 00:16:28]

http://codereview.chromium.org/8771060/diff/1/chrome/browser/resources/ntp4/t...
File chrome/browser/resources/ntp4/tile_page.js (right):

http://codereview.chromium.org/8771060/diff/1/chrome/browser/resources/ntp4/t...
chrome/browser/resources/ntp4/tile_page.js:902: usedHeight / 3 - 60;
What do you think about instead of 60 doing this once?

  var tilePaddingTop = window.parseInt(window.getComputedStyle(
      document.querySelector('.tile-page')), null).height, 10);

[csilv, 2011-12-07 00:24:47]

lgtm

[Evan Stade, 2011-12-07 00:36:14]

http://codereview.chromium.org/8771060/diff/1/chrome/browser/resources/ntp4/t...
File chrome/browser/resources/ntp4/tile_page.js (right):

http://codereview.chromium.org/8771060/diff/1/chrome/browser/resources/ntp4/t...
chrome/browser/resources/ntp4/tile_page.js:902: usedHeight / 3 - 60;
On 2011/12/07 00:16:28, Dan Beam wrote:
> What do you think about instead of 60 doing this once?
> 
>   var tilePaddingTop = window.parseInt(window.getComputedStyle(
>       document.querySelector('.tile-page')), null).height, 10);

do not want

[Dan Beam, 2011-12-07 00:39:21]

On 2011/12/07 00:36:14, Evan Stade wrote:
>
http://codereview.chromium.org/8771060/diff/1/chrome/browser/resources/ntp4/t...
> File chrome/browser/resources/ntp4/tile_page.js (right):
> 
>
http://codereview.chromium.org/8771060/diff/1/chrome/browser/resources/ntp4/t...
> chrome/browser/resources/ntp4/tile_page.js:902: usedHeight / 3 - 60;
> On 2011/12/07 00:16:28, Dan Beam wrote:
> > What do you think about instead of 60 doing this once?
> > 
> >   var tilePaddingTop = window.parseInt(window.getComputedStyle(
> >       document.querySelector('.tile-page')), null).height, 10);
> 
> do not want

Why?  You'll never get out of sync, then.  Or a % of the tile size or something?
 Hardcoding in both spots with a note seems ... ghetto.  Or at least put a
comment in tile_page.css that says something along the lines of:

  /* Update tile_page.js if you change padding-top. */

[Evan Stade, 2011-12-07 00:42:17]

On 2011/12/07 00:39:21, Dan Beam wrote:
> On 2011/12/07 00:36:14, Evan Stade wrote:
> >
>
http://codereview.chromium.org/8771060/diff/1/chrome/browser/resources/ntp4/t...
> > File chrome/browser/resources/ntp4/tile_page.js (right):
> > 
> >
>
http://codereview.chromium.org/8771060/diff/1/chrome/browser/resources/ntp4/t...
> > chrome/browser/resources/ntp4/tile_page.js:902: usedHeight / 3 - 60;
> > On 2011/12/07 00:16:28, Dan Beam wrote:
> > > What do you think about instead of 60 doing this once?
> > > 
> > >   var tilePaddingTop = window.parseInt(window.getComputedStyle(
> > >       document.querySelector('.tile-page')), null).height, 10);
> > 
> > do not want
> 
> Why?  You'll never get out of sync, then.  Or a % of the tile size or
something?

never get out of sync, at the cost of readability.

>  Hardcoding in both spots with a note seems ... ghetto.

no doubt, css is ghetto. We do this in a lot of places. I'll rejoice when we get
css variables (that can be shared in js).

>  Or at least put a
> comment in tile_page.css that says something along the lines of:
> 
>   /* Update tile_page.js if you change padding-top. */

fine

[Dan Beam, 2011-12-07 00:47:07]

lgtm

[commit-bot: I haz the power, 2011-12-07 00:52:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/estade@chromium.org/8771060/2003

[commit-bot: I haz the power, 2011-12-07 04:59:56]

Change committed as 113345