Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 8771057: aura/cc: Fix DesktopNotificationsTest (Closed)

Created:
9 years ago by piman
Modified:
9 years ago
Reviewers:
oshima
CC:
chromium-reviews, Paweł Hajdan Jr.
Visibility:
Public.

Description

aura/cc: Fix DesktopNotificationsTest BUG=None TEST=browser_tests --gtest_filter="DesktopNotificationsTest.*" with use_aura=1 and use_webkit_compositor=1 (in debug), verify no assert. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113353

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M chrome/browser/notifications/desktop_notifications_unittest.h View 2 chunks +9 lines, -0 lines 0 comments Download
M chrome/browser/notifications/desktop_notifications_unittest.cc View 1 3 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
piman
9 years ago (2011-12-06 23:31:36 UTC) #1
oshima
LGTM
9 years ago (2011-12-06 23:37:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/8771057/1
9 years ago (2011-12-07 00:22:38 UTC) #3
commit-bot: I haz the power
Can't apply patch for file chrome/browser/notifications/desktop_notifications_unittest.cc. While running patch -p1 --forward --force; patching file chrome/browser/notifications/desktop_notifications_unittest.cc ...
9 years ago (2011-12-07 00:22:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/8771057/5001
9 years ago (2011-12-07 00:32:49 UTC) #5
commit-bot: I haz the power
Try job failure for 8771057-5001 (retry) (previous was lost) on mac_rel for step "ui_tests" (clobber ...
9 years ago (2011-12-07 02:54:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/8771057/5001
9 years ago (2011-12-07 04:20:56 UTC) #7
commit-bot: I haz the power
9 years ago (2011-12-07 05:20:51 UTC) #8
Change committed as 113353

Powered by Google App Engine
This is Rietveld 408576698