Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 8771056: Add a command-line switch --enable-per-tile-painting. (Closed)

Created:
9 years ago by reveman
Modified:
9 years ago
CC:
chromium-reviews, Avi (use Gerrit), creis+watch_chromium.org, brettw-cc_chromium.org, jam, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, ajwong+watch_chromium.org, alok_chromium.org
Visibility:
Public.

Description

Add a command-line switch --enable-per-tile-painting and make it consistent by changing --enable-accelerated-drawing to --enable-accelerated-painting. With this switch, webkit compositor will paint tiles separately. BUG=none TEST=no behavior change in existing browser tests and ui tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114694

Patch Set 1 #

Patch Set 2 : enable-per-tile-painting -> enable-per-tile-drawing #

Total comments: 1

Patch Set 3 : Change back to enable-per-tile-painting. #

Patch Set 4 : Rebase on master. #

Total comments: 1

Patch Set 5 : Remove "honored only if chromium is compiled with" comment #

Patch Set 6 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -24 lines) Patch
M chrome/app/generated_resources.grd View 1 2 3 4 5 2 chunks +10 lines, -4 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 2 3 4 5 2 chunks +15 lines, -4 lines 0 comments Download
M chrome/browser/tab_contents/render_view_host_delegate_helper.cc View 1 2 3 4 5 3 chunks +5 lines, -4 lines 0 comments Download
M content/common/view_messages.h View 1 2 3 4 2 chunks +2 lines, -1 line 0 comments Download
M content/public/common/content_switches.h View 1 2 3 2 chunks +3 lines, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 2 3 4 2 chunks +5 lines, -5 lines 0 comments Download
M webkit/glue/webpreferences.h View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M webkit/glue/webpreferences.cc View 1 2 3 4 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jamesr
http://codereview.chromium.org/8771056/diff/2001/chrome/browser/about_flags.cc File chrome/browser/about_flags.cc (right): http://codereview.chromium.org/8771056/diff/2001/chrome/browser/about_flags.cc#newcode433 chrome/browser/about_flags.cc:433: "per-tile-drawing", as I mentioned on the WebKit patch, I ...
9 years ago (2011-12-08 02:31:13 UTC) #1
darin (slow to review)
LGTM
9 years ago (2011-12-13 17:15:30 UTC) #2
alokp
lgtm Are we changing the command line flag for DRT as well? It currently uses ...
9 years ago (2011-12-13 17:20:16 UTC) #3
reveman
On 2011/12/13 17:20:16, Alok Priyadarshi wrote: > lgtm > > Are we changing the command ...
9 years ago (2011-12-13 18:03:14 UTC) #4
Avi (use Gerrit)
9 years ago (2011-12-15 20:12:18 UTC) #5
owner lgtm

Powered by Google App Engine
This is Rietveld 408576698