Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: client/html/scripts/html_diff.dart

Issue 8771054: Add a script to generate HTML and DOM docs with cross-links to one another. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: More code review changes. Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « client/html/scripts/html-diff.dart ('k') | client/html/scripts/html_doc.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: client/html/scripts/html_diff.dart
diff --git a/client/html/scripts/html_diff.dart b/client/html/scripts/html_diff.dart
new file mode 100644
index 0000000000000000000000000000000000000000..f88de3869691b04e354920f557efe73ac0a0b011
--- /dev/null
+++ b/client/html/scripts/html_diff.dart
@@ -0,0 +1,333 @@
+// Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+/**
+ * A script to assist in documenting the difference between the dart:html API
+ * and the old DOM API.
+ */
+#library('html_diff');
+
+#import('../../../frog/lang.dart');
+#import('../../../frog/file_system_node.dart');
+#import('../../../frog/file_system.dart');
+#import('../../../utils/dartdoc/dartdoc.dart');
+
+void main() {
+ var files = new NodeFileSystem();
+ parseOptions('../../frog', [] /* args */, files);
+ initializeWorld(files);
+ initializeDartDoc();
+ HtmlDiff.initialize();
+
+ var diff = new HtmlDiff();
+ diff.run();
+
+ diff.domToHtml.forEach((domMember, htmlMembers) {
+ for (var htmlMember in htmlMembers) {
+ if (diff.sameName(domMember, htmlMember)) continue;
+ var htmlTypeName = htmlMember.declaringType.name;
+ var htmlName = '$htmlTypeName.${htmlMember.name}';
+ if (htmlMember.isConstructor || htmlMember.isFactory) {
+ final separator = htmlMember.constructorName == '' ? '' : '.';
+ htmlName = 'new $htmlTypeName$separator${htmlMember.constructorName}';
+ }
+ print('${domMember.declaringType.name}.${domMember.name} -> ${htmlName}');
+ }
+ });
+
+ for (var type in world.dom.types.getValues()) {
+ if (type.name == null) continue;
+ if (type.definition is FunctionTypeDefinition) continue;
+ for (var member in type.members.getValues()) {
+ if (!member.isPrivate && member.name != 'typeName' &&
+ !diff.domToHtml.containsKey(member) &&
+ (member is MethodMember || member is PropertyMember)) {
+ print('No dart:html wrapper for ${type.name}.${member.name}');
+ }
+ }
+ }
+}
+
+// TODO(nweiz): document this
+class HtmlDiff {
+ final Map<Member, Set<Member>> domToHtml;
+ final Map<Member, Set<Member>> htmlToDom;
+ final Map<Type, Set<Type>> domTypesToHtml;
+ final Map<Type, Set<Type>> htmlTypesToDom;
+
+ static void initialize() {
+ world.processDartScript('dart:htmlimpl');
+ world.resolveAll();
+ }
+
+ HtmlDiff() :
Bob Nystrom 2011/12/07 22:54:30 For future reference, I think we usually wrap that
nweiz 2011/12/07 23:01:12 Noted.
+ domToHtml = new Map<Member, Set<Member>>(),
+ htmlToDom = new Map<Member, Set<Member>>(),
+ domTypesToHtml = new Map<Type, Set<Type>>(),
+ htmlTypesToDom = new Map<Type, Set<Type>>();
+
+ void run() {
+ final htmlLib = world.libraries['dart:htmlimpl'];
+ for (var implType in htmlLib.types.getValues()) {
+ final domTypes = htmlToDomTypes(implType);
+ final htmlType = htmlImplToHtmlType(implType);
+ if (htmlType == null) continue;
+
+ htmlTypesToDom.putIfAbsent(htmlType, () => new Set()).addAll(domTypes);
+ domTypes.forEach((t) =>
+ domTypesToHtml.putIfAbsent(t, () => new Set()).add(htmlType));
+
+ final members = new List.from(implType.members.getValues());
+ members.addAll(implType.constructors.getValues());
+ implType.factories.forEach((f) => members.add(f));
+ members.forEach((m) => _addMemberDiff(m, domTypes));
+ }
+ }
+
+ bool sameName(Member domMember, Member htmlMember) {
+ var domTypeName = domMember.declaringType.name;
+ if (domTypeName == 'DOMWindow') domTypeName = 'Window';
+ domTypeName = domTypeName.replaceFirst(new RegExp('^(HTML|WebKit)'), '');
+ var htmlTypeName = htmlMember.declaringType.name;
+
+ var domName = domMember.name;
+ var htmlName = htmlMember.name;
+ if (htmlName.startsWith('get:') || htmlName.startsWith('set:')) {
+ htmlName = htmlName.substring(4);
+ }
+
+ return domTypeName == htmlTypeName && domName == htmlName;
+ }
+
+ void _addMemberDiff(Member implMember, List<Type> domTypes) {
+ if (implMember.isProperty) {
+ if (implMember.canGet) _addMemberDiff(implMember.getter, domTypes);
+ if (implMember.canSet) _addMemberDiff(implMember.setter, domTypes);
+ }
+
+ var domMembers = htmlToDomMembers(implMember, domTypes);
+ var htmlMember = htmlImplToHtmlMember(implMember);
+ if (htmlMember == null && !domMembers.isEmpty()) {
+ print('Warning: dart:htmlimpl member ${implMember.declaringType.name}.' +
+ '${implMember.name} has no corresponding dart:html member.');
+ }
+
+ if (htmlMember == null) return;
+ if (!domMembers.isEmpty()) htmlToDom[htmlMember] = domMembers;
+ domMembers.forEach((m) =>
+ domToHtml.putIfAbsent(m, () => new Set()).add(htmlMember));
+ }
+
+ Type htmlImplToHtmlType(Type implType) {
+ if (implType == null || implType.isTop || implType.interfaces.isEmpty() ||
+ implType.interfaces[0].library.name != 'html') {
+ return null;
+ }
+
+ return implType.interfaces[0];
+ }
+
+ Member htmlImplToHtmlMember(Member implMember) {
+ var htmlType = htmlImplToHtmlType(implMember.declaringType);
+ if (htmlType == null) return null;
+
+ bool getter, setter;
+ if (implMember.isConstructor || implMember.isFactory) {
+ var constructor = htmlType.constructors[implMember.name];
+ if (constructor != null) return constructor;
+ return htmlType.factories[implMember.name];
+ } else if ((getter = implMember.name.startsWith('get:')) ||
+ (setter = implMember.name.startsWith('set:'))) {
+ // Use getMember to follow interface inheritance chains. If it's a
+ // ConcreteMember, though, it's an implementation of some data structure
+ // and we don't care about it.
+ var htmlProperty = htmlType.getMember(implMember.name.substring(4));
+ if (htmlProperty != null && htmlProperty is! ConcreteMember) {
+ return getter ? htmlProperty.getter : htmlProperty.setter;
+ } else {
+ return null;
+ }
+ } else {
+ return htmlType.getMember(implMember.name);
+ }
+ }
+
+ List<Type> htmlToDomTypes(Type htmlType) {
+ if (htmlType.name == null) return [];
+ final tags = _getTags(findComment(htmlType.span));
+
+ if (tags.containsKey('domName')) {
+ var domNames = map(tags['domName'].split(','), (s) => s.trim());
+ if (domNames.length == 1 && domNames[0] == 'none') return [];
+ return map(domNames, (domName) {
+ // DOMWindow is Chrome-specific, so we don't use it in our annotations.
+ if (domName == 'Window') domName = 'DOMWindow';
+ final domType = world.dom.types[domName];
+ if (domType == null) print('Warning: no dart:dom type named $domName');
+ return domType;
+ });
+ } else {
+ if (!htmlType.name.endsWith('WrappingImplementation')) return [];
+ final domName = htmlType.name.replaceFirst('WrappingImplementation', '');
+ var domType = world.dom.types[domName];
+ if (domType == null && domName.endsWith('Element')) {
+ domType = world.dom.types['HTML$domName'];
+ }
+ if (domType == null) domType = world.dom.types['WebKit$domName'];
+ if (domType == null) {
+ print('Warning: no dart:dom type matches dart:htmlimpl ' +
+ htmlType.name);
+ return [];
+ }
+ return [domType];
+ }
+ }
+
+ Set<Member> htmlToDomMembers(Member htmlMember, List<Type> domTypes) {
+ if (htmlMember.isPrivate || htmlMember is! MethodMember) return new Set();
+ final tags = _getTags(findComment(htmlMember.span));
+ if (tags.containsKey('domName')) {
+ final domNames = map(tags['domName'].split(','), (s) => s.trim());
+ if (domNames.length == 1 && domNames[0] == 'none') return new Set();
+ final members = new Set();
+ domNames.forEach((name) {
+ var nameMembers = _membersFromName(name, domTypes);
+ if (nameMembers.isEmpty()) {
+ if (name.contains('.')) {
+ print('Warning: no member $name');
+ } else {
+ final options = Strings.join(
+ map(domTypes, (t) => "${t.name}.$name"), ' or ');
+ print('Warning: no member $options');
+ }
+ }
+ members.addAll(nameMembers);
+ });
+ return members;
+ }
+
+ if (domTypes.isEmpty() || htmlMember.definition == null) return new Set();
+ if (htmlMember.name == 'get:on') {
+ final members = _membersFromName('addEventListener', domTypes);
+ members.addAll(_membersFromName('dispatchEvent', domTypes));
+ members.addAll(_membersFromName('removeEventListener', domTypes));
+ return members;
+ }
+
+ if (htmlMember.isFactory && htmlMember.name == '' &&
+ domTypes.length == 1 && domTypes[0].name.endsWith('Event')) {
+ return _membersFromName('init${domTypes[0].name}', domTypes);
+ }
+
+ return _getDomMembers(htmlMember.definition.body, domTypes);
+ }
+
+ Set<Member> _membersFromName(String name, List<Type> defaultTypes) {
+ if (!name.contains('.', 0)) {
+ if (defaultTypes.isEmpty()) {
+ print('Warning: no default type for ${name}');
+ return new Set();
+ }
+ final members = new Set<Member>();
+ defaultTypes.forEach((t) {
+ if (t.members.containsKey(name)) members.add(t.members[name]);
+ });
+ return members;
+ }
+
+ final splitName = name.split('.');
+ if (splitName.length != 2) {
+ print('Warning: invalid member name ${name}');
+ return new Set();
+ }
+ var typeName = splitName[0];
+ if (typeName == 'Window') typeName = 'DOMWindow';
+ final type = world.dom.types[typeName];
+ if (type == null) return new Set();
+ final member = type.members[splitName[1]];
+ if (member == null) return new Set();
+ return new Set.from([member]);
+ }
+
+ Set<Member> _getDomMembers(Statement stmt, List<Type> domTypes) {
+ if (stmt is BlockStatement) {
+ final body = stmt.body.filter((s) => !_ignorableStatement(s));
+ if (body.length != 1) return new Set();
+ return _getDomMembers(stmt.body[0], domTypes);
+ } else if (stmt is ReturnStatement) {
+ return _domMembersFromExpression(stmt.value, domTypes);
+ } else if (stmt is ExpressionStatement) {
+ return _domMembersFromExpression(stmt.body, domTypes);
+ } else if (stmt is TryStatement) {
+ return _getDomMembers(stmt.body, domTypes);
+ } else if (stmt is IfStatement) {
+ final members = _getDomMembers(stmt.trueBranch, domTypes);
+ members.addAll(_getDomMembers(stmt.falseBranch, domTypes));
+ return members;
+ } else {
+ return new Set();
+ }
+ }
+
+ /**
+ * Whether a statement can be ignored for the purpose of determining the DOM
+ * name of the enclosing method. The Webkit-to-Dart conversion process leaves
+ * behind various throws and returns that we want to ignore.
+ */
+ bool _ignorableStatement(Statement stmt) {
+ if (stmt is BlockStatement) {
+ return Collections.every(stmt.body, (s) => _ignorableStatement(s));
+ } else if (stmt is TryStatement) {
+ return _ignorableStatement(stmt.body);
+ } else if (stmt is IfStatement) {
+ return _ignorableStatement(stmt.trueBranch) &&
+ _ignorableStatement(stmt.falseBranch);
+ } else if (stmt is ReturnStatement) {
+ return stmt.value == null || stmt.value is ThisExpression;
+ } else {
+ return stmt is ThrowStatement;
+ }
+ }
+
+ Set<Member> _domMembersFromExpression(Expression expr, List<Type> domTypes) {
+ if (expr is BinaryExpression && expr.op.kind == TokenKind.ASSIGN) {
+ return _domMembersFromExpression(expr.x, domTypes);
+ } else if (expr is CallExpression) {
+ if (expr.target is DotExpression && expr.target.self is VarExpression &&
+ expr.target.self.name.name == 'LevelDom' &&
+ (expr.target.name.name.startsWith('wrap') ||
+ expr.target.name.name == 'unwrap')) {
+ return _domMembersFromExpression(expr.arguments[0].value, domTypes);
+ }
+ return _domMembersFromExpression(expr.target, domTypes);
+ } else if (expr is DotExpression) {
+ if (expr.self is NewExpression && expr.name.name == '_wrap' &&
+ expr.self.arguments.length == 1) {
+ return _domMembersFromExpression(expr.self.arguments[0].value,
+ domTypes);
+ } else if (expr.self is VarExpression && expr.self.name.name == '_ptr') {
+ return _membersFromName(expr.name.name, domTypes);
+ }
+ final bases = _domMembersFromExpression(expr.self, domTypes);
+ return new Set.from(map(bases, (base) {
+ if (base == null || base.returnType == null) return null;
+ return base.returnType.members[expr.name.name];
+ }).filter((m) => m != null));
+ } else if (expr is NewExpression && expr.arguments.length == 1) {
+ return _domMembersFromExpression(expr.arguments[0].value, domTypes);
+ } else {
+ return new Set();
+ }
+ }
+
+ Map<String, String> _getTags(String comment) {
+ if (comment == null) return const <String>{};
+ final re = new RegExp("@([a-zA-Z]+) ([^;]+)(?:;|\$)");
+ final tags = <String>{};
+ for (var m in re.allMatches(comment.trim())) {
+ tags[m[1]] = m[2];
+ }
+ return tags;
+ }
+}
« no previous file with comments | « client/html/scripts/html-diff.dart ('k') | client/html/scripts/html_doc.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698