Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 8771046: Fix gyp warnings about missing files. (Closed)

Created:
9 years ago by Lei Zhang
Modified:
9 years ago
Reviewers:
sky
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, tfarina, dpranke-watch+content_chromium.org
Visibility:
Public.

Description

Fix gyp warnings about missing files. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112849

Patch Set 1 : '' #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M chrome/chrome_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/content_browser.gypi View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/views.gyp View 1 chunk +2 lines, -2 lines 1 comment Download

Messages

Total messages: 5 (0 generated)
Lei Zhang
As seen at the end of http://build.chromium.org/p/chromium/builders/Win/builds/8396/steps/update/logs/stdio
9 years ago (2011-12-02 20:17:13 UTC) #1
tfarina
http://codereview.chromium.org/8771046/diff/2001/ui/views/views.gyp File ui/views/views.gyp (right): http://codereview.chromium.org/8771046/diff/2001/ui/views/views.gyp#newcode374 ui/views/views.gyp:374: 'window/custom_frame_view.h', ops, that was probably me.
9 years ago (2011-12-02 20:18:47 UTC) #2
sky
LGTM
9 years ago (2011-12-02 20:28:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/8771046/2001
9 years ago (2011-12-02 21:36:35 UTC) #4
commit-bot: I haz the power
9 years ago (2011-12-03 02:05:25 UTC) #5
Change committed as 112849

Powered by Google App Engine
This is Rietveld 408576698