Issue 8771045: Add new appNotifications permission to built-in webstore app

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8771045: Add new appNotifications permission to built-in webstore app (Closed)

Created:
9 years ago by asargent_no_longer_on_chrome

Modified:
9 years ago

Reviewers:
Munjal (Google)

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add new appNotifications permission to built-in webstore app This is so we can use the webstore app for dogfood experiments. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112813

Patch Set 1 #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	chrome/browser/resources/webstore_app/manifest.json	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asargent@chromium.org/8771045/1

9 years ago (2011-12-02 21:42:21 UTC) #3

commit-bot: I haz the power

9 years ago (2011-12-02 21:42:23 UTC) #4

Presubmit check for 8771045-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for:
chrome/browser/resources/webstore_app/manifest.json

Expand Messages | Collapse Messages