Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1027)

Unified Diff: chrome/browser/nacl_host/nacl_process_host.cc

Issue 8771041: Simplify BrowserChildProcessHost in preparation for refactoring it so that consumers embed it in ... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: fix nacl on win64 Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/nacl_host/nacl_process_host.h ('k') | content/browser/browser_child_process_host.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/nacl_host/nacl_process_host.cc
===================================================================
--- chrome/browser/nacl_host/nacl_process_host.cc (revision 112769)
+++ chrome/browser/nacl_host/nacl_process_host.cc (working copy)
@@ -149,6 +149,10 @@
reply_msg_->set_reply_error();
chrome_render_message_filter_->Send(reply_msg_);
}
+
+#if defined(OS_WIN)
+ NaClBrokerService::GetInstance()->OnLoaderDied();
+#endif
}
// Attempt to ensure the IRT will be available when we need it, but don't wait.
@@ -293,11 +297,10 @@
OnProcessLaunched();
}
-base::TerminationStatus NaClProcessHost::GetChildTerminationStatus(
- int* exit_code) {
- if (RunningOnWOW64())
- return base::GetTerminationStatus(handle(), exit_code);
- return BrowserChildProcessHost::GetChildTerminationStatus(exit_code);
+void NaClProcessHost::OnProcessCrashed(int exit_code) {
+ std::string message = base::StringPrintf(
+ "NaCl process exited with status %i (0x%x)", exit_code, exit_code);
+ LOG(ERROR) << message;
}
// This only ever runs on the BrowserThread::FILE thread.
« no previous file with comments | « chrome/browser/nacl_host/nacl_process_host.h ('k') | content/browser/browser_child_process_host.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698