Issue 8771041: Simplify BrowserChildProcessHost in preparation for refactoring it so that consumers embed it in ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8771041: Simplify BrowserChildProcessHost in preparation for refactoring it so that consumers embed it in ... (Closed)

Created:
9 years ago by jam

Modified:
9 years ago

Reviewers:
bbudge

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, native-client-reviews_googlegroups.com, dpranke-watch+content_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Simplify BrowserChildProcessHost in preparation for refactoring it so that consumers embed it in their class instead of deriving from it. The GetChildTerminationStatus override in NaclProcessHost seemed unnecessary since that's what the default implementation does. NaClProcessHost::OnChildDied can be done in the destructor. BUG=98716 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112877

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -24 lines)			Patch
M	chrome/browser/nacl_host/nacl_process_host.h	View	1 2	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/nacl_host/nacl_process_host.cc	View	1 2	2 chunks	+8 lines, -5 lines	0 comments	Download
M	content/browser/browser_child_process_host.h	View	1 2	1 chunk	+2 lines, -8 lines	0 comments	Download
M	content/browser/browser_child_process_host.cc	View	1 2 3 4	2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/public/browser/notification_types.h	View	1 2	1 chunk	+0 lines, -7 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages

Issue 8771041: Simplify BrowserChildProcessHost in preparation for refactoring it so that consumers embed it in ... (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : fix nacl on win64 #

Messages