Issue 8771032: Cleanup: Use a scoper in JSModalDialogViews.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8771032: Cleanup: Use a scoper in JSModalDialogViews. (Closed)

Created:
9 years ago by Lei Zhang

Modified:
9 years ago

Reviewers:
zel

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Cleanup: Use a scoper in JSModalDialogViews. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112771

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -6 lines)			Patch
	M	chrome/browser/ui/views/js_modal_dialog_views.h	View		2 chunks	+4 lines, -4 lines	0 comments	Download
	M	chrome/browser/ui/views/js_modal_dialog_views.cc	View		2 chunks	+1 line, -2 lines	0 comments	Download

Total messages: 4 (0 generated)

Lei Zhang

Not sure if it happens in the real world, but if JSModalDialogViews::DeleteDelegate() didn't get called, ...

9 years ago (2011-12-02 10:13:29 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/8771032/1

9 years ago (2011-12-02 18:50:05 UTC) #3

Change committed as 112771