Add NSS function to retrieve TLS client cert types requested by server.

Add NSS function to retrieve TLS client cert types requested by server.

BUG=88782
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113109

[mattm, 2011-12-02 03:54:00]

(I can work on making a net/third_party/nss/patches for this once the initial
review is done.)

I tested this with some debug logging (patchset 1)

[wtc, 2011-12-02 22:31:46]

Patch Set 2 LGTM.


SSL_(Get)RequestedClientCertificateTypes might be a better name
for the function.

The comment should describe how to parse the returned
SECItem.  I guess no parsing is needed.  Each byte is a
ClientCertificateType value.

http://codereview.chromium.org/8771031/diff/1005/net/third_party/nss/ssl/ssl.h
File net/third_party/nss/ssl/ssl.h (right):

http://codereview.chromium.org/8771031/diff/1005/net/third_party/nss/ssl/ssl....
net/third_party/nss/ssl/ssl.h:804: ** the callback returns, and should not be
freed.

Document that this function returns NULL if called at the
wrong time.

http://codereview.chromium.org/8771031/diff/1005/net/third_party/nss/ssl/ssl3...
File net/third_party/nss/ssl/ssl3con.c (right):

http://codereview.chromium.org/8771031/diff/1005/net/third_party/nss/ssl/ssl3...
net/third_party/nss/ssl/ssl3con.c:5554: ss->requestedCertTypes = &cert_types;

Add
    PORT_Assert(!ss->requestedCertTypes);
before this line.

http://codereview.chromium.org/8771031/diff/1005/net/third_party/nss/ssl/ssli...
File net/third_party/nss/ssl/sslimpl.h (right):

http://codereview.chromium.org/8771031/diff/1005/net/third_party/nss/ssl/ssli...
net/third_party/nss/ssl/sslimpl.h:1112: SECItem*          requestedCertTypes;

This probably should be const SECItem*.

Nit: put '*' next to requestedCertTypes.

http://codereview.chromium.org/8771031/diff/1005/net/third_party/nss/ssl/ssls...
File net/third_party/nss/ssl/sslsock.c (right):

http://codereview.chromium.org/8771031/diff/1005/net/third_party/nss/ssl/ssls...
net/third_party/nss/ssl/sslsock.c:1618: SSL_IMPORT

Remove SSL_IMPORT, and put
  SECItem *
on its own line.

Put the opening curly brace '{' on its own line.  (That's
the NSS style.)

http://codereview.chromium.org/8771031/diff/1005/net/third_party/nss/ssl/ssls...
net/third_party/nss/ssl/sslsock.c:2615: ss->stepDownKeyPair    = NULL;
Let's also set
    ss->requestedCertTypes = NULL;
here, before this line.

[mattm, 2011-12-06 00:32:01]

Updated and added patch.  (bugzilla not responding for me, I'll post it there
later.)

http://codereview.chromium.org/8771031/diff/1005/net/third_party/nss/ssl/ssl.h
File net/third_party/nss/ssl/ssl.h (right):

http://codereview.chromium.org/8771031/diff/1005/net/third_party/nss/ssl/ssl....
net/third_party/nss/ssl/ssl.h:804: ** the callback returns, and should not be
freed.
On 2011/12/02 22:31:46, wtc wrote:
> 
> Document that this function returns NULL if called at the
> wrong time.

Done.

http://codereview.chromium.org/8771031/diff/1005/net/third_party/nss/ssl/ssl3...
File net/third_party/nss/ssl/ssl3con.c (right):

http://codereview.chromium.org/8771031/diff/1005/net/third_party/nss/ssl/ssl3...
net/third_party/nss/ssl/ssl3con.c:5554: ss->requestedCertTypes = &cert_types;
On 2011/12/02 22:31:46, wtc wrote:
> 
> Add
>     PORT_Assert(!ss->requestedCertTypes);
> before this line.

Done.

http://codereview.chromium.org/8771031/diff/1005/net/third_party/nss/ssl/ssli...
File net/third_party/nss/ssl/sslimpl.h (right):

http://codereview.chromium.org/8771031/diff/1005/net/third_party/nss/ssl/ssli...
net/third_party/nss/ssl/sslimpl.h:1112: SECItem*          requestedCertTypes;
On 2011/12/02 22:31:46, wtc wrote:
> 
> This probably should be const SECItem*.
> 
> Nit: put '*' next to requestedCertTypes.

Done.

http://codereview.chromium.org/8771031/diff/1005/net/third_party/nss/ssl/ssls...
File net/third_party/nss/ssl/sslsock.c (right):

http://codereview.chromium.org/8771031/diff/1005/net/third_party/nss/ssl/ssls...
net/third_party/nss/ssl/sslsock.c:1618: SSL_IMPORT
On 2011/12/02 22:31:46, wtc wrote:
> 
> Remove SSL_IMPORT, and put
>   SECItem *
> on its own line.
> 
> Put the opening curly brace '{' on its own line.  (That's
> the NSS style.)

Done.

http://codereview.chromium.org/8771031/diff/1005/net/third_party/nss/ssl/ssls...
net/third_party/nss/ssl/sslsock.c:2615: ss->stepDownKeyPair    = NULL;
On 2011/12/02 22:31:46, wtc wrote:
> Let's also set
>     ss->requestedCertTypes = NULL;
> here, before this line.

Done.

[wtc, 2011-12-06 00:45:57]

Patch Set 3 LGTM.