Making profile avatars and names sync.

chrome/browser/profiles/profile_info_cache.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/profiles/profile_info_cache.h"
 
 #include "base/bind.h"
 #include "base/file_util.h"
 #include "base/format_macros.h"
 #include "base/i18n/case_conversion.h"
@@ skipping 600 matching lines @@
   return user_data_dir_;
 }
 
 // static
 size_t ProfileInfoCache::GetDefaultAvatarIconCount() {
   return kDefaultAvatarIconsCount;
 }
 
 // static
 int ProfileInfoCache::GetDefaultAvatarIconResourceIDAtIndex(size_t index) {
-  DCHECK_LT(index, GetDefaultAvatarIconCount());
+  DCHECK(IsDefaultAvatarIconIndex(index));
   return kDefaultAvatarIconResources[index];
 }
 
 // static
 std::string ProfileInfoCache::GetDefaultAvatarIconUrl(size_t index) {
-  DCHECK_LT(index, kDefaultAvatarIconsCount);
+  DCHECK(IsDefaultAvatarIconIndex(index));
   return StringPrintf("%s%" PRIuS, kDefaultUrlPrefix, index);
 }
 
 // static
+bool ProfileInfoCache::IsDefaultAvatarIconIndex(size_t index) {
+  return index<kDefaultAvatarIconsCount;

[sail, 2011/12/02 19:07:10]

space before and after "<"

[jwd, 2011/12/02 21:10:16]

Done.

+}
+
+// static
 bool ProfileInfoCache::IsDefaultAvatarIconUrl(const std::string& url,
                                               size_t* icon_index) {
   DCHECK(icon_index);
   if (url.find(kDefaultUrlPrefix) != 0)
     return false;
 
   int int_value = -1;
   if (base::StringToInt(url.begin() + strlen(kDefaultUrlPrefix),
                         url.end(),
                         &int_value)) {
@@ skipping 86 matching lines @@
     info->GetString(kNameKey, &name);
     names.push_back(name);
   }
   return names;
 }
 
 // static
 void ProfileInfoCache::RegisterPrefs(PrefService* prefs) {
   prefs->RegisterDictionaryPref(prefs::kProfileInfoCache);
 }