Issue 8771022: Fix Android build: shmem

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8771022: Fix Android build: shmem (Closed)

Created:
9 years ago by John Grabowski

Modified:
9 years ago

Reviewers:
Nico

CC:
chromium-reviews, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix Android build. Accomodate shmem changes in http://codereview.chromium.org/8585002. BUG=None TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112588

Patch Set 1 #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	base/shared_memory_android.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Roland McGrath

D'oh! I knew I couldn't do the compile but I thought I'd triple-checked the code ...

9 years ago (2011-12-02 01:26:07 UTC) #3

John Grabowski

9 years ago (2011-12-02 01:33:55 UTC) #4

Is fine.  Normal cliches apply.  E.g.
did not try it --> does not work
did not compile it --> it won't compile
jrg did not yet make an android trybot --> every non-jrg CL breaks android
bot

jrg

On Thu, Dec 1, 2011 at 5:26 PM, <mcgrathr@chromium.org> wrote:

> D'oh!  I knew I couldn't do the compile but I thought I'd triple-checked
> the
> code for obvious bugs like those.
>
> Thanks, John.
>
>
http://codereview.chromium.**org/8771022/<http://codereview.chromium.org/8771...
>

Expand Messages | Collapse Messages