Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5096)

Unified Diff: chrome/browser/chromeos/options/wifi_config_view.cc

Issue 8771019: Don't require login to enable CA cert settings (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/options/wifi_config_view.cc
diff --git a/chrome/browser/chromeos/options/wifi_config_view.cc b/chrome/browser/chromeos/options/wifi_config_view.cc
index a56486332cef16c17a779370fc2a46d3e642016f..82197a562ccb1033883a89f03c8776a7021ba8ae 100644
--- a/chrome/browser/chromeos/options/wifi_config_view.cc
+++ b/chrome/browser/chromeos/options/wifi_config_view.cc
@@ -188,15 +188,10 @@ class ServerCACertComboboxModel : public ui::ComboboxModel {
}
virtual ~ServerCACertComboboxModel() {}
virtual int GetItemCount() {
zel 2011/12/02 00:07:23 if (!UserManager::Get()->user_is_logged_in()) re
- if (!cert_library_->CertificatesLoaded())
- return 1; // "Loading"
- // First "Default", then the certs, then "Do not check".
+ // First "Default", then the certs (if any), then "Do not check".
return cert_library_->GetCACertificates().Size() + 2;
}
virtual string16 GetItemAt(int combo_index) {
- if (!cert_library_->CertificatesLoaded())
- return l10n_util::GetStringUTF16(
- IDS_OPTIONS_SETTINGS_INTERNET_OPTIONS_CERT_LOADING);
if (combo_index == 0)
return l10n_util::GetStringUTF16(
IDS_OPTIONS_SETTINGS_INTERNET_OPTIONS_CERT_SERVER_CA_DEFAULT);
@@ -400,7 +395,6 @@ void WifiConfigView::RefreshEapFields() {
(selected != EAP_METHOD_INDEX_NONE && selected != EAP_METHOD_INDEX_LEAP);
server_ca_cert_label_->SetEnabled(ca_cert_enabled);
server_ca_cert_combobox_->SetEnabled(ca_cert_enabled &&
zel 2011/12/02 00:07:23 disable this if user is not logged in by adding co
stevenjb 2011/12/02 01:26:33 We should probably leave this enabled in case user
- !certs_loading &&
server_ca_cert_ui_data_.editable());
server_ca_cert_combobox_->ModelChanged();
server_ca_cert_combobox_->SetSelectedItem(0);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698