Don't require login to enable CA cert settings

chrome/browser/chromeos/cros/cert_library.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/cros/cert_library.h"
 
 #include <algorithm>
 
 #include "base/observer_list_threadsafe.h"
 #include "base/utf_string_conversions.h"
@@ skipping 66 matching lines @@
   CertLibraryImpl() :
       observer_list_(new CertLibraryObserverList),
       user_logged_in_(false),
       certificates_loaded_(false),
       ALLOW_THIS_IN_INITIALIZER_LIST(certs_(this)),
       ALLOW_THIS_IN_INITIALIZER_LIST(user_certs_(this)),
       ALLOW_THIS_IN_INITIALIZER_LIST(server_certs_(this)),
       ALLOW_THIS_IN_INITIALIZER_LIST(server_ca_certs_(this)) {
     CHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
     net::CertDatabase::AddObserver(this);
+    // For now, if we are not logged in, set certificates_loaded_ to true
+    // since RequestCertificates() may never get called.
+    // TODO(stevenjb, zel): Handle loading of not hardware backed certificates
+    // when not logged in.
+    if (!UserManager::Get()->user_is_logged_in())
+      certificates_loaded_ = true;

[zel, 2011/12/02 01:45:26]

that's not going to work since this same instance of this class is used before
and after user signs in. in other words, the constructor for this singleton
object will always end with certificates_loaded_ set to true since when the
first time we call it, user won't be signed in

[stevenjb, 2011/12/02 02:20:59]

That's already handled in RequestCertificates() - the first time it gets called
where UserManager::Get()->user_is_logged_in() is true,  it sets
certificates_loaded_ = false. This is just to handle the case where
Requestcertificates() doesn't get called.

   }
 
   ~CertLibraryImpl() {
     DCHECK(request_task_.is_null());
     net::CertDatabase::RemoveObserver(this);
   }
 
   // CertLibrary implementation.
   virtual void RequestCertificates() OVERRIDE {
     DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
@@ skipping 306 matching lines @@
     net::X509Certificate* cert = GetCertificateAt(index);
     net::X509Certificate::OSCertHandle cert_handle = cert->os_cert_handle();
     std::string id = x509_certificate_model::GetPkcs11Id(cert_handle);
     if (id == pkcs11_id)
       return index;
   }
   return -1;  // Not found.
 }
 
 }  // chromeos