Index: ui/aura_shell/root_window_event_filter_unittest.cc |
=================================================================== |
--- ui/aura_shell/root_window_event_filter_unittest.cc (revision 113260) |
+++ ui/aura_shell/root_window_event_filter_unittest.cc (working copy) |
@@ -2,11 +2,11 @@ |
// Use of this source code is governed by a BSD-style license that can be |
// found in the LICENSE file. |
-#include "ui/aura_shell/desktop_event_filter.h" |
+#include "ui/aura_shell/root_window_event_filter.h" |
#include "ui/aura/cursor.h" |
-#include "ui/aura/desktop.h" |
#include "ui/aura/event.h" |
+#include "ui/aura/root_window.h" |
#include "ui/aura/test/aura_test_base.h" |
#include "ui/aura/test/event_generator.h" |
#include "ui/aura/test/test_windows.h" |
@@ -20,24 +20,24 @@ |
namespace aura_shell { |
namespace test { |
-class DesktopEventFilterTest : public aura::test::AuraTestBase { |
+class RootWindowEventFilterTest : public aura::test::AuraTestBase { |
public: |
- DesktopEventFilterTest() { |
- aura::Desktop::GetInstance()->SetEventFilter( |
- new internal::DesktopEventFilter); |
+ RootWindowEventFilterTest() { |
+ aura::RootWindow::GetInstance()->SetEventFilter( |
+ new internal::RootWindowEventFilter); |
aura::test::TestStackingClient* stacking_client = |
static_cast<aura::test::TestStackingClient*>( |
- aura::Desktop::GetInstance()->stacking_client()); |
+ aura::RootWindow::GetInstance()->stacking_client()); |
stacking_client->default_container()->set_id( |
internal::kShellWindowId_DefaultContainer); |
} |
- virtual ~DesktopEventFilterTest() { |
- aura::Desktop::GetInstance()->SetEventFilter(NULL); |
+ virtual ~RootWindowEventFilterTest() { |
+ aura::RootWindow::GetInstance()->SetEventFilter(NULL); |
} |
private: |
- DISALLOW_COPY_AND_ASSIGN(DesktopEventFilterTest); |
+ DISALLOW_COPY_AND_ASSIGN(RootWindowEventFilterTest); |
}; |
class HitTestWindowDelegate : public aura::test::TestWindowDelegate { |
@@ -59,9 +59,9 @@ |
DISALLOW_COPY_AND_ASSIGN(HitTestWindowDelegate); |
}; |
-TEST_F(DesktopEventFilterTest, Focus) { |
- aura::Desktop* desktop = aura::Desktop::GetInstance(); |
- desktop->SetBounds(gfx::Rect(0, 0, 510, 510)); |
+TEST_F(RootWindowEventFilterTest, Focus) { |
+ aura::RootWindow* root_window = aura::RootWindow::GetInstance(); |
+ root_window->SetBounds(gfx::Rect(0, 0, 510, 510)); |
// Supplied ids are negative so as not to collide with shell ids. |
// TODO(beng): maybe introduce a MAKE_SHELL_ID() macro that generates a safe |
@@ -89,40 +89,40 @@ |
// Click on a sub-window (w121) to focus it. |
gfx::Point click_point = w121->bounds().CenterPoint(); |
- aura::Window::ConvertPointToWindow(w121->parent(), desktop, &click_point); |
+ aura::Window::ConvertPointToWindow(w121->parent(), root_window, &click_point); |
aura::MouseEvent mouse(ui::ET_MOUSE_PRESSED, click_point, |
ui::EF_LEFT_BUTTON_DOWN); |
- desktop->DispatchMouseEvent(&mouse); |
+ root_window->DispatchMouseEvent(&mouse); |
aura::internal::FocusManager* focus_manager = w121->GetFocusManager(); |
EXPECT_EQ(w121.get(), focus_manager->GetFocusedWindow()); |
// The key press should be sent to the focused sub-window. |
aura::KeyEvent keyev(ui::ET_KEY_PRESSED, ui::VKEY_E, 0); |
- desktop->DispatchKeyEvent(&keyev); |
+ root_window->DispatchKeyEvent(&keyev); |
EXPECT_EQ(ui::VKEY_E, w121delegate->last_key_code()); |
// Touch on a sub-window (w122) to focus it. |
click_point = w122->bounds().CenterPoint(); |
- aura::Window::ConvertPointToWindow(w122->parent(), desktop, &click_point); |
+ aura::Window::ConvertPointToWindow(w122->parent(), root_window, &click_point); |
aura::TouchEvent touchev(ui::ET_TOUCH_PRESSED, click_point, 0); |
- desktop->DispatchTouchEvent(&touchev); |
+ root_window->DispatchTouchEvent(&touchev); |
focus_manager = w122->GetFocusManager(); |
EXPECT_EQ(w122.get(), focus_manager->GetFocusedWindow()); |
// The key press should be sent to the focused sub-window. |
- desktop->DispatchKeyEvent(&keyev); |
+ root_window->DispatchKeyEvent(&keyev); |
EXPECT_EQ(ui::VKEY_E, w122delegate->last_key_code()); |
// Removing the focused window from parent should reset the focused window. |
w12->RemoveChild(w122.get()); |
EXPECT_EQ(NULL, w122->GetFocusManager()); |
EXPECT_EQ(NULL, w12->GetFocusManager()->GetFocusedWindow()); |
- EXPECT_FALSE(desktop->DispatchKeyEvent(&keyev)); |
+ EXPECT_FALSE(root_window->DispatchKeyEvent(&keyev)); |
} |
// Various assertion testing for activating windows. |
-TEST_F(DesktopEventFilterTest, ActivateOnMouse) { |
- aura::Desktop* desktop = aura::Desktop::GetInstance(); |
+TEST_F(RootWindowEventFilterTest, ActivateOnMouse) { |
+ aura::RootWindow* root_window = aura::RootWindow::GetInstance(); |
aura::test::ActivateWindowDelegate d1; |
scoped_ptr<aura::Window> w1(aura::test::CreateTestWindowWithDelegate( |
@@ -136,8 +136,8 @@ |
d2.Clear(); |
// Activate window1. |
- desktop->SetActiveWindow(w1.get(), NULL); |
- EXPECT_EQ(w1.get(), desktop->active_window()); |
+ root_window->SetActiveWindow(w1.get(), NULL); |
+ EXPECT_EQ(w1.get(), root_window->active_window()); |
EXPECT_EQ(w1.get(), focus_manager->GetFocusedWindow()); |
EXPECT_EQ(1, d1.activated_count()); |
EXPECT_EQ(0, d1.lost_active_count()); |
@@ -145,12 +145,12 @@ |
// Click on window2. |
gfx::Point press_point = w2->bounds().CenterPoint(); |
- aura::Window::ConvertPointToWindow(w2->parent(), desktop, &press_point); |
+ aura::Window::ConvertPointToWindow(w2->parent(), root_window, &press_point); |
aura::test::EventGenerator generator(press_point); |
generator.ClickLeftButton(); |
// Window2 should have become active. |
- EXPECT_EQ(w2.get(), desktop->active_window()); |
+ EXPECT_EQ(w2.get(), root_window->active_window()); |
EXPECT_EQ(w2.get(), focus_manager->GetFocusedWindow()); |
EXPECT_EQ(0, d1.activated_count()); |
EXPECT_EQ(1, d1.lost_active_count()); |
@@ -161,12 +161,12 @@ |
// Click back on window1, but set it up so w1 doesn't activate on click. |
press_point = w1->bounds().CenterPoint(); |
- aura::Window::ConvertPointToWindow(w1->parent(), desktop, &press_point); |
+ aura::Window::ConvertPointToWindow(w1->parent(), root_window, &press_point); |
d1.set_activate(false); |
generator.ClickLeftButton(); |
// Window2 should still be active and focused. |
- EXPECT_EQ(w2.get(), desktop->active_window()); |
+ EXPECT_EQ(w2.get(), root_window->active_window()); |
EXPECT_EQ(w2.get(), focus_manager->GetFocusedWindow()); |
EXPECT_EQ(0, d1.activated_count()); |
EXPECT_EQ(0, d1.lost_active_count()); |
@@ -180,15 +180,15 @@ |
w2.reset(); |
EXPECT_EQ(0, d2.activated_count()); |
EXPECT_EQ(0, d2.lost_active_count()); |
- EXPECT_EQ(w1.get(), desktop->active_window()); |
+ EXPECT_EQ(w1.get(), root_window->active_window()); |
EXPECT_EQ(w1.get(), focus_manager->GetFocusedWindow()); |
EXPECT_EQ(1, d1.activated_count()); |
EXPECT_EQ(0, d1.lost_active_count()); |
} |
// Essentially the same as ActivateOnMouse, but for touch events. |
-TEST_F(DesktopEventFilterTest, ActivateOnTouch) { |
- aura::Desktop* desktop = aura::Desktop::GetInstance(); |
+TEST_F(RootWindowEventFilterTest, ActivateOnTouch) { |
+ aura::RootWindow* root_window = aura::RootWindow::GetInstance(); |
aura::test::ActivateWindowDelegate d1; |
scoped_ptr<aura::Window> w1(aura::test::CreateTestWindowWithDelegate( |
@@ -202,8 +202,8 @@ |
d2.Clear(); |
// Activate window1. |
- desktop->SetActiveWindow(w1.get(), NULL); |
- EXPECT_EQ(w1.get(), desktop->active_window()); |
+ root_window->SetActiveWindow(w1.get(), NULL); |
+ EXPECT_EQ(w1.get(), root_window->active_window()); |
EXPECT_EQ(w1.get(), focus_manager->GetFocusedWindow()); |
EXPECT_EQ(1, d1.activated_count()); |
EXPECT_EQ(0, d1.lost_active_count()); |
@@ -211,12 +211,12 @@ |
// Touch window2. |
gfx::Point press_point = w2->bounds().CenterPoint(); |
- aura::Window::ConvertPointToWindow(w2->parent(), desktop, &press_point); |
+ aura::Window::ConvertPointToWindow(w2->parent(), root_window, &press_point); |
aura::TouchEvent touchev1(ui::ET_TOUCH_PRESSED, press_point, 0); |
- desktop->DispatchTouchEvent(&touchev1); |
+ root_window->DispatchTouchEvent(&touchev1); |
// Window2 should have become active. |
- EXPECT_EQ(w2.get(), desktop->active_window()); |
+ EXPECT_EQ(w2.get(), root_window->active_window()); |
EXPECT_EQ(w2.get(), focus_manager->GetFocusedWindow()); |
EXPECT_EQ(0, d1.activated_count()); |
EXPECT_EQ(1, d1.lost_active_count()); |
@@ -227,13 +227,13 @@ |
// Touch window1, but set it up so w1 doesn't activate on touch. |
press_point = w1->bounds().CenterPoint(); |
- aura::Window::ConvertPointToWindow(w1->parent(), desktop, &press_point); |
+ aura::Window::ConvertPointToWindow(w1->parent(), root_window, &press_point); |
d1.set_activate(false); |
aura::TouchEvent touchev2(ui::ET_TOUCH_PRESSED, press_point, 0); |
- desktop->DispatchTouchEvent(&touchev2); |
+ root_window->DispatchTouchEvent(&touchev2); |
// Window2 should still be active and focused. |
- EXPECT_EQ(w2.get(), desktop->active_window()); |
+ EXPECT_EQ(w2.get(), root_window->active_window()); |
EXPECT_EQ(w2.get(), focus_manager->GetFocusedWindow()); |
EXPECT_EQ(0, d1.activated_count()); |
EXPECT_EQ(0, d1.lost_active_count()); |
@@ -247,14 +247,14 @@ |
w2.reset(); |
EXPECT_EQ(0, d2.activated_count()); |
EXPECT_EQ(0, d2.lost_active_count()); |
- EXPECT_EQ(w1.get(), desktop->active_window()); |
+ EXPECT_EQ(w1.get(), root_window->active_window()); |
EXPECT_EQ(w1.get(), focus_manager->GetFocusedWindow()); |
EXPECT_EQ(1, d1.activated_count()); |
EXPECT_EQ(0, d1.lost_active_count()); |
} |
-TEST_F(DesktopEventFilterTest, MouseEventCursors) { |
- aura::Desktop* desktop = aura::Desktop::GetInstance(); |
+TEST_F(RootWindowEventFilterTest, MouseEventCursors) { |
+ aura::RootWindow* root_window = aura::RootWindow::GetInstance(); |
// Create a window. |
const int kWindowLeft = 123; |
@@ -268,58 +268,58 @@ |
// Create two mouse movement events we can switch between. |
gfx::Point point1(kWindowLeft, kWindowTop); |
- aura::Window::ConvertPointToWindow(window->parent(), desktop, &point1); |
+ aura::Window::ConvertPointToWindow(window->parent(), root_window, &point1); |
aura::MouseEvent move1(ui::ET_MOUSE_MOVED, point1, 0x0); |
gfx::Point point2(kWindowLeft + 1, kWindowTop + 1); |
- aura::Window::ConvertPointToWindow(window->parent(), desktop, &point2); |
+ aura::Window::ConvertPointToWindow(window->parent(), root_window, &point2); |
aura::MouseEvent move2(ui::ET_MOUSE_MOVED, point2, 0x0); |
// Cursor starts as null. |
- EXPECT_EQ(aura::kCursorNull, desktop->last_cursor()); |
+ EXPECT_EQ(aura::kCursorNull, root_window->last_cursor()); |
// Resize edges and corners show proper cursors. |
window_delegate.set_hittest_code(HTBOTTOM); |
- desktop->DispatchMouseEvent(&move1); |
- EXPECT_EQ(aura::kCursorSouthResize, desktop->last_cursor()); |
+ root_window->DispatchMouseEvent(&move1); |
+ EXPECT_EQ(aura::kCursorSouthResize, root_window->last_cursor()); |
window_delegate.set_hittest_code(HTBOTTOMLEFT); |
- desktop->DispatchMouseEvent(&move2); |
- EXPECT_EQ(aura::kCursorSouthWestResize, desktop->last_cursor()); |
+ root_window->DispatchMouseEvent(&move2); |
+ EXPECT_EQ(aura::kCursorSouthWestResize, root_window->last_cursor()); |
window_delegate.set_hittest_code(HTBOTTOMRIGHT); |
- desktop->DispatchMouseEvent(&move1); |
- EXPECT_EQ(aura::kCursorSouthEastResize, desktop->last_cursor()); |
+ root_window->DispatchMouseEvent(&move1); |
+ EXPECT_EQ(aura::kCursorSouthEastResize, root_window->last_cursor()); |
window_delegate.set_hittest_code(HTLEFT); |
- desktop->DispatchMouseEvent(&move2); |
- EXPECT_EQ(aura::kCursorWestResize, desktop->last_cursor()); |
+ root_window->DispatchMouseEvent(&move2); |
+ EXPECT_EQ(aura::kCursorWestResize, root_window->last_cursor()); |
window_delegate.set_hittest_code(HTRIGHT); |
- desktop->DispatchMouseEvent(&move1); |
- EXPECT_EQ(aura::kCursorEastResize, desktop->last_cursor()); |
+ root_window->DispatchMouseEvent(&move1); |
+ EXPECT_EQ(aura::kCursorEastResize, root_window->last_cursor()); |
window_delegate.set_hittest_code(HTTOP); |
- desktop->DispatchMouseEvent(&move2); |
- EXPECT_EQ(aura::kCursorNorthResize, desktop->last_cursor()); |
+ root_window->DispatchMouseEvent(&move2); |
+ EXPECT_EQ(aura::kCursorNorthResize, root_window->last_cursor()); |
window_delegate.set_hittest_code(HTTOPLEFT); |
- desktop->DispatchMouseEvent(&move1); |
- EXPECT_EQ(aura::kCursorNorthWestResize, desktop->last_cursor()); |
+ root_window->DispatchMouseEvent(&move1); |
+ EXPECT_EQ(aura::kCursorNorthWestResize, root_window->last_cursor()); |
window_delegate.set_hittest_code(HTTOPRIGHT); |
- desktop->DispatchMouseEvent(&move2); |
- EXPECT_EQ(aura::kCursorNorthEastResize, desktop->last_cursor()); |
+ root_window->DispatchMouseEvent(&move2); |
+ EXPECT_EQ(aura::kCursorNorthEastResize, root_window->last_cursor()); |
// Client area uses null cursor. |
window_delegate.set_hittest_code(HTCLIENT); |
- desktop->DispatchMouseEvent(&move1); |
- EXPECT_EQ(aura::kCursorNull, desktop->last_cursor()); |
+ root_window->DispatchMouseEvent(&move1); |
+ EXPECT_EQ(aura::kCursorNull, root_window->last_cursor()); |
} |
-TEST_F(DesktopEventFilterTest, TransformActivate) { |
- aura::Desktop* desktop = aura::Desktop::GetInstance(); |
- gfx::Size size = desktop->GetHostSize(); |
+TEST_F(RootWindowEventFilterTest, TransformActivate) { |
+ aura::RootWindow* root_window = aura::RootWindow::GetInstance(); |
+ gfx::Size size = root_window->GetHostSize(); |
EXPECT_EQ(gfx::Rect(size), |
gfx::Screen::GetMonitorAreaNearestPoint(gfx::Point())); |
@@ -327,7 +327,7 @@ |
ui::Transform transform; |
transform.SetRotate(90.0f); |
transform.ConcatTranslate(size.width(), 0); |
- desktop->SetTransform(transform); |
+ root_window->SetTransform(transform); |
aura::test::ActivateWindowDelegate d1; |
scoped_ptr<aura::Window> w1( |
@@ -339,30 +339,30 @@ |
aura::MouseEvent mouseev1(ui::ET_MOUSE_PRESSED, |
miss_point, |
ui::EF_LEFT_BUTTON_DOWN); |
- desktop->DispatchMouseEvent(&mouseev1); |
+ root_window->DispatchMouseEvent(&mouseev1); |
EXPECT_FALSE(w1->GetFocusManager()->GetFocusedWindow()); |
aura::MouseEvent mouseup(ui::ET_MOUSE_RELEASED, |
miss_point, |
ui::EF_LEFT_BUTTON_DOWN); |
- desktop->DispatchMouseEvent(&mouseup); |
+ root_window->DispatchMouseEvent(&mouseup); |
gfx::Point hit_point(5, 15); |
transform.TransformPoint(hit_point); |
aura::MouseEvent mouseev2(ui::ET_MOUSE_PRESSED, |
hit_point, |
ui::EF_LEFT_BUTTON_DOWN); |
- desktop->DispatchMouseEvent(&mouseev2); |
- EXPECT_EQ(w1.get(), desktop->active_window()); |
+ root_window->DispatchMouseEvent(&mouseev2); |
+ EXPECT_EQ(w1.get(), root_window->active_window()); |
EXPECT_EQ(w1.get(), w1->GetFocusManager()->GetFocusedWindow()); |
} |
-TEST_F(DesktopEventFilterTest, AdditionalFilters) { |
- aura::Desktop* desktop = aura::Desktop::GetInstance(); |
+TEST_F(RootWindowEventFilterTest, AdditionalFilters) { |
+ aura::RootWindow* root_window = aura::RootWindow::GetInstance(); |
// Creates a window and make it active |
scoped_ptr<aura::Window> w1(aura::test::CreateTestWindow( |
SK_ColorWHITE, -1, gfx::Rect(0, 0, 100, 100), NULL)); |
- desktop->SetActiveWindow(w1.get(), NULL); |
+ root_window->SetActiveWindow(w1.get(), NULL); |
// Creates two addition filters |
scoped_ptr<aura::test::TestEventFilter> f1( |
@@ -370,17 +370,18 @@ |
scoped_ptr<aura::test::TestEventFilter> f2( |
new aura::test::TestEventFilter(NULL)); |
- // Adds them to desktop event filter. |
- internal::DesktopEventFilter* desktop_filter = |
- static_cast<internal::DesktopEventFilter*>(desktop->event_filter()); |
- desktop_filter->AddFilter(f1.get()); |
- desktop_filter->AddFilter(f2.get()); |
+ // Adds them to root window event filter. |
+ internal::RootWindowEventFilter* root_window_filter = |
+ static_cast<internal::RootWindowEventFilter*>( |
+ root_window->event_filter()); |
+ root_window_filter->AddFilter(f1.get()); |
+ root_window_filter->AddFilter(f2.get()); |
// Dispatches mouse and keyboard events. |
aura::KeyEvent key_event(ui::ET_KEY_PRESSED, ui::VKEY_A, 0); |
- desktop->DispatchKeyEvent(&key_event); |
+ root_window->DispatchKeyEvent(&key_event); |
aura::MouseEvent mouse_pressed(ui::ET_MOUSE_PRESSED, gfx::Point(0, 0), 0x0); |
- desktop->DispatchMouseEvent(&mouse_pressed); |
+ root_window->DispatchMouseEvent(&mouse_pressed); |
// Both filters should get the events. |
EXPECT_EQ(1, f1->key_event_count()); |
@@ -396,9 +397,9 @@ |
f1->set_consumes_mouse_events(true); |
// Dispatches events. |
- desktop->DispatchKeyEvent(&key_event); |
+ root_window->DispatchKeyEvent(&key_event); |
aura::MouseEvent mouse_released(ui::ET_MOUSE_RELEASED, gfx::Point(0, 0), 0x0); |
- desktop->DispatchMouseEvent(&mouse_released); |
+ root_window->DispatchMouseEvent(&mouse_released); |
// f1 should still get the events but f2 no longer gets them. |
EXPECT_EQ(1, f1->key_event_count()); |
@@ -410,11 +411,11 @@ |
f2->ResetCounts(); |
// Remove f1 from additonal filters list. |
- desktop_filter->RemoveFilter(f1.get()); |
+ root_window_filter->RemoveFilter(f1.get()); |
// Dispatches events. |
- desktop->DispatchKeyEvent(&key_event); |
- desktop->DispatchMouseEvent(&mouse_pressed); |
+ root_window->DispatchKeyEvent(&key_event); |
+ root_window->DispatchMouseEvent(&mouse_pressed); |
// f1 should get no events since it's out and f2 should get them. |
EXPECT_EQ(0, f1->key_event_count()); |
@@ -422,7 +423,7 @@ |
EXPECT_EQ(1, f2->key_event_count()); |
EXPECT_EQ(1, f2->mouse_event_count()); |
- desktop_filter->RemoveFilter(f2.get()); |
+ root_window_filter->RemoveFilter(f2.get()); |
} |
} // namespace test |