Issue 8771002: Remove OVERRIDEs from methods inherited from WebKit API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8771002: Remove OVERRIDEs from methods inherited from WebKit API (Closed)

Created:
9 years ago by Takashi Toyoshima

Modified:
9 years ago

Reviewers:
dmichael (off chromium), brettw, piman

CC:
chromium-reviews, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove OVERRIDEs from methods inherited from WebKit API BUG=105708 TEST=ui_tests --gtest_filter='PPAPITest.WebSocket*' Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112634

Patch Set 1 #

Patch Set 2 : rebase #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -8 lines)			Patch
	M	webkit/plugins/ppapi/ppb_websocket_impl.h	View		1 chunk	+6 lines, -8 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Takashi Toyoshima

Just remove OVERRIDE from methods which are inherited from WebKit API. This change is based ...

9 years ago (2011-12-01 08:45:48 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/toyoshim@chromium.org/8771002/1

9 years ago (2011-12-02 01:15:56 UTC) #3

commit-bot: I haz the power

Presubmit check for 8771002-1 failed and returned exit status 1. Running presubmit commit checks ...

9 years ago (2011-12-02 01:15:59 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/toyoshim@chromium.org/8771002/1

9 years ago (2011-12-02 02:14:00 UTC) #6

commit-bot: I haz the power

9 years ago (2011-12-02 02:21:46 UTC) #7

Try job failure for 8771002-1 on win_rel for step "update".
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Step "update" is always a major failure.
Look at the try server FAQ for more details.

Expand Messages | Collapse Messages