Stop about:tracing from dropping child slices of didNotFinish slices.

Stop about:tracing from dropping child slices of didNotFinish slices.

BUG=98473
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112538

[nduca, 2011-12-01 08:26:59]

On 2011/12/01 08:21:09, nduca wrote:

The json reference file shows as empty because it not follow the 80col
conventions. In this case, its a HUGE trace and manually formatting it would be
really impractical, even with fixjsstyle. :'(

[James Hawkins, 2011-12-01 17:12:49]

http://codereview.chromium.org/8771001/diff/1/chrome/browser/resources/tracin...
File chrome/browser/resources/tracing/test_utils.js (left):

http://codereview.chromium.org/8771001/diff/1/chrome/browser/resources/tracin...
chrome/browser/resources/tracing/test_utils.js:32: });
What is this diff?

http://codereview.chromium.org/8771001/diff/1/chrome/browser/resources/tracin...
File chrome/browser/resources/tracing/timeline_model.js (right):

http://codereview.chromium.org/8771001/diff/1/chrome/browser/resources/tracin...
chrome/browser/resources/tracing/timeline_model.js:510: // any of the open
slices, since they wouldn't have been inluded in the
included

http://codereview.chromium.org/8771001/diff/1/chrome/browser/resources/tracin...
chrome/browser/resources/tracing/timeline_model.js:520: for (var s = 0; s <
slice.slice.subSlices.length; ++s) {
s++

http://codereview.chromium.org/8771001/diff/1/chrome/browser/resources/tracin...
File chrome/browser/resources/tracing/timeline_model_test.html (right):

http://codereview.chromium.org/8771001/diff/1/chrome/browser/resources/tracin...
chrome/browser/resources/tracing/timeline_model_test.html:112: assertEquals('a',
slice.title);
expectX for all of these.

[nduca, 2011-12-01 17:30:33]

http://codereview.chromium.org/8771001/diff/1/chrome/browser/resources/tracin...
File chrome/browser/resources/tracing/test_utils.js (left):

http://codereview.chromium.org/8771001/diff/1/chrome/browser/resources/tracin...
chrome/browser/resources/tracing/test_utils.js:32: });
On 2011/12/01 17:12:49, James Hawkins wrote:
> What is this diff?
Trailing newline.

http://codereview.chromium.org/8771001/diff/1/chrome/browser/resources/tracin...
File chrome/browser/resources/tracing/timeline_model.js (right):

http://codereview.chromium.org/8771001/diff/1/chrome/browser/resources/tracin...
chrome/browser/resources/tracing/timeline_model.js:510: // any of the open
slices, since they wouldn't have been inluded in the
On 2011/12/01 17:12:49, James Hawkins wrote:
> included

Done.

http://codereview.chromium.org/8771001/diff/1/chrome/browser/resources/tracin...
chrome/browser/resources/tracing/timeline_model.js:520: for (var s = 0; s <
slice.slice.subSlices.length; ++s) {
On 2011/12/01 17:12:49, James Hawkins wrote:
> s++

Done.

http://codereview.chromium.org/8771001/diff/1/chrome/browser/resources/tracin...
File chrome/browser/resources/tracing/timeline_model_test.html (right):

http://codereview.chromium.org/8771001/diff/1/chrome/browser/resources/tracin...
chrome/browser/resources/tracing/timeline_model_test.html:112: assertEquals('a',
slice.title);
On 2011/12/01 17:12:49, James Hawkins wrote:
> expectX for all of these.

Closure jsunit doesn't have expect. :'(

[jbates, 2011-12-01 17:49:17]

lgtm

[James Hawkins, 2011-12-01 17:49:23]

http://codereview.chromium.org/8771001/diff/1/chrome/browser/resources/tracin...
File chrome/browser/resources/tracing/timeline_model_test.html (right):

http://codereview.chromium.org/8771001/diff/1/chrome/browser/resources/tracin...
chrome/browser/resources/tracing/timeline_model_test.html:112: assertEquals('a',
slice.title);
On 2011/12/01 17:30:33, nduca wrote:
> On 2011/12/01 17:12:49, James Hawkins wrote:
> > expectX for all of these.
> 
> Closure jsunit doesn't have expect. :'(

Hmm, expectEquals is used on line 29 of this file in the latest patch set.

[nduca, 2011-12-01 17:55:41]

hahah i suck.

[James Hawkins, 2011-12-01 17:56:35]

LGTM. You should look into using our own WebUI testing infrastructure for this
asap.

[nduca, 2011-12-01 17:58:11]

On 2011/12/01 17:56:35, James Hawkins wrote:
> LGTM. You should look into using our own WebUI testing infrastructure for this
> asap.

Yeah, I've been discussing with @scr what makes sense. However, webui tests nor
the dom-less equivalent are quite the right matches for this. Anyways, yes, I'm
on it.

[commit-bot: I haz the power, 2011-12-01 21:00:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nduca@chromium.org/8771001/5003

[commit-bot: I haz the power, 2011-12-01 21:04:56]

Try job failure for 8771001-5003 on win_rel for step "update".
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Step "update" is always a major failure.
Look at the try server FAQ for more details.