Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Issue 8770051: Add a few permissions to the optional permission whitelist. (Closed)

Created:
9 years ago by jstritar
Modified:
9 years ago
CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, mihaip+watch_chromium.org
Visibility:
Public.

Description

Add a few permissions to the optional permission whitelist. Whitelists the following permissions: - contentSettings - pageCapture - webNavigation - webRequest - webRequestBlocking BUG=105630 TEST=existing Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112821

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -120 lines) Patch
M chrome/common/extensions/docs/bookmarks.html View 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/common/extensions/docs/contentSettings.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/experimental.app.html View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/experimental.devtools.audits.html View 20 chunks +32 lines, -32 lines 0 comments Download
M chrome/common/extensions/docs/experimental.devtools.inspectedWindow.html View 9 chunks +13 lines, -13 lines 0 comments Download
M chrome/common/extensions/docs/experimental.devtools.panels.html View 29 chunks +31 lines, -31 lines 0 comments Download
M chrome/common/extensions/docs/experimental.storage.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/extension.html View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/common/extensions/docs/omnibox.html View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/common/extensions/docs/permissions.html View 1 2 2 chunks +7 lines, -1 line 0 comments Download
M chrome/common/extensions/docs/static/permissions.html View 1 2 2 chunks +7 lines, -1 line 0 comments Download
M chrome/common/extensions/docs/tabs.html View 8 chunks +10 lines, -10 lines 0 comments Download
M chrome/common/extensions/docs/types.html View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/webRequest.html View 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/common/extensions/extension_permission_set.cc View 2 chunks +8 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jstritar
Can you take a look? Not sure why the doc script needed to touch so ...
9 years ago (2011-12-02 18:01:04 UTC) #1
asargent_no_longer_on_chrome
lgtm Out of curiousity, was there a reason we went with a API whitelist instead ...
9 years ago (2011-12-02 19:06:03 UTC) #2
jstritar
Originally did the whitelist because some modules needed to update internal state when activated (they ...
9 years ago (2011-12-02 19:36:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jstritar@chromium.org/8770051/5001
9 years ago (2011-12-02 21:18:11 UTC) #4
commit-bot: I haz the power
9 years ago (2011-12-02 23:58:01 UTC) #5
Change committed as 112821

Powered by Google App Engine
This is Rietveld 408576698