Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 8770044: [filebrowser] Yet another animation in gallery ribbon. (Closed)

Created:
9 years ago by dgozman
Modified:
9 years ago
CC:
chromium-reviews, rginda+watch_chromium.org, arv (Not doing code reviews), achuith+watch_chromium.org
Visibility:
Public.

Description

[filebrowser] Yet another animation in gallery ribbon. BUG=chromium-os:23434 TEST=See bug. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112969

Patch Set 1 #

Total comments: 4

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -178 lines) Patch
M chrome/browser/resources/file_manager/js/image_editor/gallery.css View 4 chunks +17 lines, -45 lines 0 comments Download
M chrome/browser/resources/file_manager/js/image_editor/gallery.js View 1 6 chunks +106 lines, -133 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
dgozman
Please, take a look.
9 years ago (2011-12-02 15:17:40 UTC) #1
Vladislav Kaznacheev
http://codereview.chromium.org/8770044/diff/1/chrome/browser/resources/file_manager/js/image_editor/gallery.js File chrome/browser/resources/file_manager/js/image_editor/gallery.js (right): http://codereview.chromium.org/8770044/diff/1/chrome/browser/resources/file_manager/js/image_editor/gallery.js#newcode656 chrome/browser/resources/file_manager/js/image_editor/gallery.js:656: var box = this.items_[index].getBox(0); shall we get rid of ...
9 years ago (2011-12-02 15:45:13 UTC) #2
dgozman
http://codereview.chromium.org/8770044/diff/1/chrome/browser/resources/file_manager/js/image_editor/gallery.js File chrome/browser/resources/file_manager/js/image_editor/gallery.js (right): http://codereview.chromium.org/8770044/diff/1/chrome/browser/resources/file_manager/js/image_editor/gallery.js#newcode656 chrome/browser/resources/file_manager/js/image_editor/gallery.js:656: var box = this.items_[index].getBox(0); On 2011/12/02 15:45:13, Vladislav Kaznacheev ...
9 years ago (2011-12-05 09:16:57 UTC) #3
Vladislav Kaznacheev
lgtm
9 years ago (2011-12-05 09:19:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/8770044/3001
9 years ago (2011-12-05 09:26:05 UTC) #5
commit-bot: I haz the power
9 years ago (2011-12-05 10:37:14 UTC) #6
Change committed as 112969

Powered by Google App Engine
This is Rietveld 408576698