Issue 8770038: DevTools: remove devtools interactive tests suppressions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8770038: DevTools: remove devtools interactive tests suppressions. (Closed)

Created:
9 years ago by pfeldman

Modified:
9 years ago

Reviewers:
Scott Hess - ex-Googler, yurys

CC:
chromium-reviews, Paweł Hajdan Jr., Avi (use Gerrit)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

DevTools: remove devtools interactive tests suppressions. BUG=106114 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112688

Patch Set 1 #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -6 lines)			Patch
	M	chrome/browser/debugger/devtools_sanity_unittest.cc	View		2 chunks	+2 lines, -6 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Scott Hess - ex-Googler

Note that PauseInSharedWorkerInitialization is now making the ChromiumOS Linux bots red. Any volunteers?

9 years ago (2011-12-02 20:34:17 UTC) #3

Avi (use Gerrit)

I'd rather revert for now. Avi On Fri, Dec 2, 2011 at 3:34 PM, <shess@chromium.org> ...

9 years ago (2011-12-02 20:37:05 UTC) #4

pfeldman

9 years ago (2011-12-02 20:41:04 UTC) #5

I did fix it upstream prior to unsuppressing. It did pass locally for me.
Please revert and I'll sort it out later. Sorry for trouble.

Pavel
On Dec 3, 2011 12:37 AM, "Avi Drissman" <avi@chromium.org> wrote:

> I'd rather revert for now.
>
> Avi
>
> On Fri, Dec 2, 2011 at 3:34 PM, <shess@chromium.org> wrote:
>
>> Note that PauseInSharedWorkerInitializat**ion is now making the
>> ChromiumOS Linux
>> bots red.  Any volunteers?
>>
>>
http://codereview.chromium.**org/8770038/<http://codereview.chromium.org/8770...
>>
>
>

Expand Messages | Collapse Messages