Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 8770036: NTP4: Found more remnants of bookmarks page. (Closed)

Created:
9 years ago by Dan Beam
Modified:
9 years ago
Reviewers:
csilv, Evan Stade
CC:
chromium-reviews, estade+watch_chromium.org, arv (Not doing code reviews)
Visibility:
Public.

Description

NTP4: Found more remnants of bookmarks page. BUG=105941 R=csilv@chromium.org TEST=[ "`grep -Rin 'bookmark' chrome/browser/resources/ntp4/ | grep -v 'BOOKMARKS_PANE' | wc -l`" -eq 0 ] && echo 'Yay!' Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113026

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -19 lines) Patch
M chrome/browser/resources/ntp4/apps_page.js View 2 chunks +1 line, -8 lines 0 comments Download
M chrome/browser/resources/ntp4/new_tab_theme.css View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
csilv
lgtm, thanks!
9 years ago (2011-12-02 18:27:32 UTC) #1
Dan Beam
9 years ago (2011-12-02 18:30:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/8770036/1
9 years ago (2011-12-02 22:15:21 UTC) #3
commit-bot: I haz the power
Presubmit check for 8770036-1 failed and returned exit status 1. Running presubmit commit checks ...
9 years ago (2011-12-02 22:15:24 UTC) #4
Dan Beam
+estade for OWNERS check / review
9 years ago (2011-12-02 22:17:03 UTC) #5
Evan Stade
lg
9 years ago (2011-12-05 02:27:04 UTC) #6
Evan Stade
On 2011/12/05 02:27:04, Evan Stade wrote: > lgtm
9 years ago (2011-12-05 02:27:10 UTC) #7
Evan Stade
lgtm
9 years ago (2011-12-05 02:27:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/8770036/1
9 years ago (2011-12-05 16:41:24 UTC) #9
commit-bot: I haz the power
9 years ago (2011-12-05 21:26:49 UTC) #10
Change committed as 113026

Powered by Google App Engine
This is Rietveld 408576698