Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Unified Diff: chrome/browser/sync/test/integration/two_client_sessions_sync_test.cc

Issue 8770032: [Sync] Implement encryption-aware conflict resolution. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Split out nigori conflict code and rebase Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/test/integration/two_client_sessions_sync_test.cc
diff --git a/chrome/browser/sync/test/integration/two_client_sessions_sync_test.cc b/chrome/browser/sync/test/integration/two_client_sessions_sync_test.cc
index 8748125be735b7d921036c918a053ac78047375f..cd2dff6f18a2c55916aa46e9e0870f4c0d2d486a 100644
--- a/chrome/browser/sync/test/integration/two_client_sessions_sync_test.cc
+++ b/chrome/browser/sync/test/integration/two_client_sessions_sync_test.cc
@@ -256,7 +256,7 @@ IN_PROC_BROWSER_TEST_F(TwoClientSessionsSyncTest,
client1_windows.GetMutable()));
// At this point we enter the passphrase, triggering a resync, in which the
- // local changes of client 1 get overwritten for now.
+ // local changes of client 1 get sent to client 0.
GetClient(1)->service()->SetPassphrase(kValidPassphrase, true);
ASSERT_TRUE(GetClient(1)->AwaitPassphraseAccepted());
ASSERT_TRUE(GetClient(1)->WaitForTypeEncryption(syncable::SESSIONS));
@@ -265,12 +265,9 @@ IN_PROC_BROWSER_TEST_F(TwoClientSessionsSyncTest,
ASSERT_TRUE(IsEncrypted(0, syncable::SESSIONS));
ASSERT_TRUE(IsEncrypted(1, syncable::SESSIONS));
- // The session data from client 1 got overwritten. As a result, client 0
- // should have no foreign session data. TODO(zea): update this once bug 76596
- // is resolved and we don't choose server wins on encryption conflicts.
SyncedSessionVector sessions0;
SyncedSessionVector sessions1;
- ASSERT_FALSE(GetSessionData(0, &sessions0));
+ ASSERT_TRUE(GetSessionData(0, &sessions0));
ASSERT_FALSE(GetSessionData(1, &sessions1));
}

Powered by Google App Engine
This is Rietveld 408576698