Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2680)

Unified Diff: chrome/browser/sync/engine/get_commit_ids_command.cc

Issue 8770032: [Sync] Implement encryption-aware conflict resolution. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Split out nigori conflict code and rebase Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/engine/get_commit_ids_command.cc
diff --git a/chrome/browser/sync/engine/get_commit_ids_command.cc b/chrome/browser/sync/engine/get_commit_ids_command.cc
index fa847f7c4223ab665851d8179c060731d029a21d..720c063f23d13663a8e7cc5f34ec3340dbbb7203 100644
--- a/chrome/browser/sync/engine/get_commit_ids_command.cc
+++ b/chrome/browser/sync/engine/get_commit_ids_command.cc
@@ -87,7 +87,6 @@ bool IsEntryReadyForCommit(syncable::ModelTypeSet encrypted_types,
// The local and server versions don't match. The item must be in
// conflict, so there's no point in attempting to commit.
DCHECK(entry.Get(syncable::IS_UNAPPLIED_UPDATE)); // In conflict.
- // TODO(zea): switch this to DVLOG once it's clear bug 100660 is fixed.
DVLOG(1) << "Excluding entry from commit due to version mismatch "
<< entry;
return false;
@@ -104,7 +103,6 @@ bool IsEntryReadyForCommit(syncable::ModelTypeSet encrypted_types,
// This entry requires encryption but is not properly encrypted (possibly
// due to the cryptographer not being initialized or the user hasn't
// provided the most recent passphrase).
- // TODO(zea): switch this to DVLOG once it's clear bug 100660 is fixed.
DVLOG(1) << "Excluding entry from commit due to lack of encryption "
<< entry;
return false;

Powered by Google App Engine
This is Rietveld 408576698