Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 8770029: Remove views dependencies in content_browser.gypi (Closed)

Created:
9 years ago by alicet1
Modified:
9 years ago
Reviewers:
jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, dpranke-watch+content_chromium.org, Ben Goodger (Google)
Visibility:
Public.

Description

Remove views dependencies in content_browser.gypi src/content should not depend on src/views. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112644

Patch Set 1 #

Patch Set 2 : merge #

Patch Set 3 : update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M content/content_browser.gypi View 1 2 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
alicet1
hopefully the dependency is not needed anymore? thanx, alice
9 years ago (2011-12-02 00:05:44 UTC) #1
jam
lgtm
9 years ago (2011-12-02 02:02:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alicet@chromium.org/8770029/2001
9 years ago (2011-12-02 04:28:32 UTC) #3
commit-bot: I haz the power
Try job failure for 8770029-2001 on win_rel for step "update". http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=3227 Step "update" is always ...
9 years ago (2011-12-02 04:31:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alicet@chromium.org/8770029/5001
9 years ago (2011-12-02 04:39:52 UTC) #5
commit-bot: I haz the power
9 years ago (2011-12-02 05:45:13 UTC) #6
Change committed as 112644

Powered by Google App Engine
This is Rietveld 408576698