Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1407)

Unified Diff: content/common/child_process_info.h

Issue 8770027: Get rid of the ChildProcessInfo class. It was carrying unnecessary data, and the fact that some p... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/common/child_process_host.cc ('k') | content/common/child_process_info.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/child_process_info.h
===================================================================
--- content/common/child_process_info.h (revision 112500)
+++ content/common/child_process_info.h (working copy)
@@ -1,83 +0,0 @@
-// Copyright (c) 2011 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#ifndef CONTENT_COMMON_CHILD_PROCESS_INFO_H_
-#define CONTENT_COMMON_CHILD_PROCESS_INFO_H_
-#pragma once
-
-#include <string>
-
-#include "base/process.h"
-#include "base/string16.h"
-#include "content/common/content_export.h"
-#include "content/public/common/process_type.h"
-
-// Holds information about a child process.
-class CONTENT_EXPORT ChildProcessInfo {
- public:
- ChildProcessInfo(const ChildProcessInfo& original);
- virtual ~ChildProcessInfo();
-
- ChildProcessInfo& operator=(const ChildProcessInfo& original);
-
- // Returns the type of the process.
- content::ProcessType type() const { return type_; }
-
- // Returns the name of the process. i.e. for plugins it might be Flash, while
- // for workers it might be the domain that it's from.
- const string16& name() const { return name_; }
-
- // Returns the version of the exe, this only applies to plugins. Otherwise
- // the string is empty.
- const string16& version() const { return version_; }
-
- // Getter to the process handle.
- base::ProcessHandle handle() const { return process_.handle(); }
-
- // Getter to the process ID.
- int pid() const { return process_.pid(); }
-
- // The unique identifier for this child process. This identifier is NOT a
- // process ID, and will be unique for all types of child process for
- // one run of the browser.
- int id() const { return id_; }
-
- void SetProcessBackgrounded() const { process_.SetProcessBackgrounded(true); }
-
- // Generates a unique channel name for a child renderer/plugin process.
- // The "instance" pointer value is baked into the channel id.
- static std::string GenerateRandomChannelID(void* instance);
-
- // Returns a unique ID to identify a child process. On construction, this
- // function will be used to generate the id_, but it is also used to generate
- // IDs for the RenderProcessHost, which doesn't inherit from us, and whose IDs
- // must be unique for all child processes.
- //
- // This function is threadsafe since RenderProcessHost is on the UI thread,
- // but normally this will be used on the IO thread.
- static int GenerateChildProcessUniqueId();
-
- protected:
- // Derived objects need to use this constructor so we know what type we are.
- // If the caller has already generated a unique ID for this child process,
- // it should pass it as the second argument. Otherwise, -1 should be passed
- // and a unique ID will be automatically generated.
- ChildProcessInfo(content::ProcessType type, int id);
-
- void set_type(content::ProcessType type) { type_ = type; }
- void set_name(const string16& name) { name_ = name; }
- void set_version(const string16& ver) { version_ = ver; }
- void set_handle(base::ProcessHandle handle) { process_.set_handle(handle); }
-
- private:
- content::ProcessType type_;
- string16 name_;
- string16 version_;
- int id_;
-
- // The handle to the process.
- mutable base::Process process_;
-};
-
-#endif // CONTENT_COMMON_CHILD_PROCESS_INFO_H_
« no previous file with comments | « content/common/child_process_host.cc ('k') | content/common/child_process_info.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698