Zygote most of the uses of the utility process on Linux

content/browser/utility_process_host.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_UTILITY_PROCESS_HOST_H_
 #define CONTENT_BROWSER_UTILITY_PROCESS_HOST_H_
 #pragma once
 
 #include <string>
 #include <vector>
@@ skipping 51 matching lines @@
 
   // Ends the utility process. Must be called after StartBatchMode().
   void EndBatchMode();
 
   void set_exposed_dir(const FilePath& dir) { exposed_dir_ = dir; }
   void set_no_sandbox(bool flag) { no_sandbox_ = flag; }
   void set_child_flags(int flags) { child_flags_ = flags; }
 #if defined(OS_POSIX)
   void set_env(const base::environment_vector& env) { env_ = env; }
 #endif
+#if defined(OS_LINUX)
+  void set_should_use_zygote(bool flag) { should_use_zygote_ = flag; }
+#endif
 
  protected:
   // Allow these methods to be overridden for tests.
   virtual FilePath GetUtilityProcessCmd();
 
  private:
   // Starts a process if necessary.  Returns true if it succeeded or a process
   // has already been started via StartBatchMode().
   bool StartProcess();
 
@@ skipping 16 matching lines @@
   FilePath exposed_dir_;
 
   // Whether to pass switches::kNoSandbox to the child.
   bool no_sandbox_;
 
   // Flags defined in ChildProcessHost with which to start the process.
   int child_flags_;
 
   base::environment_vector env_;
 
+#if defined(OS_LINUX)

[Aaron Boodman, 2011/12/02 03:10:04]

It's a shame to require #ifdefs at all the call sites. Can we just have this
compiled in for all platforms and make it a no-op for non-linux?

Also, I think the 'should' is redundant. How about use_zygote_, or
use_linux_zygote_.

[Jorge Lucangeli Obes, 2011/12/02 18:27:16]

SGTM, will do.

+  // If the |no_sandbox_| flag is off, launch the utility process from the
+  // zygote.
+  // Can only be used for tasks that do not require FS access.
+  bool should_use_zygote_;
+#endif
+
   bool started_;
 
   DISALLOW_COPY_AND_ASSIGN(UtilityProcessHost);
 };
 
 #endif  // CONTENT_BROWSER_UTILITY_PROCESS_HOST_H_