Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(877)

Unified Diff: chrome/browser/download/download_manager_unittest.cc

Issue 8770024: Added a download file factory to the download file manager, for testing. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Minor cleanup. Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/download/download_file_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/download/download_manager_unittest.cc
diff --git a/chrome/browser/download/download_manager_unittest.cc b/chrome/browser/download/download_manager_unittest.cc
index b99007e9bd0fd8b4d53c9e1ec71fffb78a3d667c..4bd969dc863774c07b40e3a566791863379a099f 100644
--- a/chrome/browser/download/download_manager_unittest.cc
+++ b/chrome/browser/download/download_manager_unittest.cc
@@ -55,6 +55,28 @@
#define MAYBE_DownloadRemoveTest DownloadRemoveTest
#endif
+namespace {
+
+class MockDownloadFileFactory
+ : public DownloadFileManager::DownloadFileFactory {
+ public:
+ MockDownloadFileFactory() {}
+
+ virtual DownloadFile* CreateFile(DownloadCreateInfo* info,
+ const DownloadRequestHandle& request_handle,
+ DownloadManager* download_manager) OVERRIDE;
+};
+
+DownloadFile* MockDownloadFileFactory::CreateFile(
+ DownloadCreateInfo* info,
+ const DownloadRequestHandle& request_handle,
+ DownloadManager* download_manager) {
+ NOTREACHED();
+ return NULL;
+}
+
+} // namespace
+
using content::BrowserThread;
DownloadId::Domain kValidIdDomain = "valid DownloadId::Domain";
@@ -149,7 +171,8 @@ class DownloadManagerTest : public testing::Test {
DownloadFileManager* file_manager() {
if (!file_manager_) {
- file_manager_ = new DownloadFileManager(NULL);
+ file_manager_ = new DownloadFileManager(NULL,
+ new MockDownloadFileFactory);
download_manager_->SetFileManager(file_manager_);
}
return file_manager_;
« no previous file with comments | « no previous file | content/browser/download/download_file_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698