Added a download file factory to the download file manager, for testing.

content/browser/download/download_file_manager.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // The DownloadFileManager owns a set of DownloadFile objects, each of which
 // represent one in progress download and performs the disk IO for that
 // download. The DownloadFileManager itself is a singleton object owned by the
 // ResourceDispatcherHost.
 //
 // The DownloadFileManager uses the file_thread for performing file write
@@ skipping 51 matching lines @@
 class ResourceDispatcherHost;
 
 namespace content {
 class DownloadBuffer;
 }
 
 // Manages all in progress downloads.
 class CONTENT_EXPORT DownloadFileManager
     : public base::RefCountedThreadSafe<DownloadFileManager> {
  public:
-  explicit DownloadFileManager(ResourceDispatcherHost* rdh);
+  class DownloadFileFactory {
+   public:
+    virtual ~DownloadFileFactory() {}
+
+    virtual DownloadFile* GetFile(DownloadCreateInfo* info,

[Randy Smith (Not in Mondays), 2011/12/05 22:25:38]

nit, suggestion: I'd call this CreateFile.

[ahendrickson, 2011/12/07 19:55:15]

Done.

+                                  const DownloadRequestHandle& request_handle,
+                                  DownloadManager* download_manager) = 0;
+  };
+
+  // Takes ownership of the factory.
+  DownloadFileManager(ResourceDispatcherHost* rdh,
+                      DownloadFileFactory* factory);
 
   // Called on shutdown on the UI thread.
   void Shutdown();
 
   // Called on UI thread to make DownloadFileManager start the download.
   void StartDownload(DownloadCreateInfo* info,
                      const DownloadRequestHandle& request_handle);
 
   // Handlers for notifications sent from the IO thread and run on the
   // FILE thread.
@@ skipping 75 matching lines @@
   typedef base::hash_map<DownloadId, DownloadFile*> DownloadFileMap;
 
   // A map of all in progress downloads.  It owns the download files.
   DownloadFileMap downloads_;
 
   // Schedule periodic updates of the download progress. This timer
   // is controlled from the FILE thread, and posts updates to the UI thread.
   base::RepeatingTimer<DownloadFileManager> update_timer_;
 
   ResourceDispatcherHost* resource_dispatcher_host_;
+  DownloadFileFactory* download_file_factory_;

[cbentzel, 2011/12/07 18:58:21]

this should be a scoped_ptr if it takes ownership

[ahendrickson, 2011/12/07 19:55:15]

Done.

 
   DISALLOW_COPY_AND_ASSIGN(DownloadFileManager);
 };
 
 #endif  // CONTENT_BROWSER_DOWNLOAD_DOWNLOAD_FILE_MANAGER_H_