Added a download file factory to the download file manager, for testing.

content/browser/download/download_file_manager.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // The DownloadFileManager owns a set of DownloadFile objects, each of which
 // represent one in progress download and performs the disk IO for that
 // download. The DownloadFileManager itself is a singleton object owned by the
 // ResourceDispatcherHost.
 //
 // The DownloadFileManager uses the file_thread for performing file write
@@ skipping 29 matching lines @@
 #define CONTENT_BROWSER_DOWNLOAD_DOWNLOAD_FILE_MANAGER_H_
 #pragma once
 
 #include <map>
 
 #include "base/atomic_sequence_num.h"
 #include "base/basictypes.h"
 #include "base/gtest_prod_util.h"
 #include "base/hash_tables.h"
 #include "base/memory/ref_counted.h"
+#include "base/memory/scoped_ptr.h"
 #include "base/timer.h"
 #include "content/browser/download/download_id.h"
 #include "content/browser/download/interrupt_reasons.h"
 #include "content/common/content_export.h"
 #include "net/base/net_errors.h"
 #include "ui/gfx/native_widget_types.h"
 
 struct DownloadCreateInfo;
 class DownloadFile;
 class DownloadManager;
 class DownloadRequestHandle;
 class FilePath;
 class ResourceDispatcherHost;
 
 namespace content {
 class DownloadBuffer;
 }
 
 // Manages all in progress downloads.
 class CONTENT_EXPORT DownloadFileManager
     : public base::RefCountedThreadSafe<DownloadFileManager> {
  public:
-  explicit DownloadFileManager(ResourceDispatcherHost* rdh);
+  class DownloadFileFactory {
+   public:
+    virtual ~DownloadFileFactory() {}
+
+    virtual DownloadFile* CreateFile(
+        DownloadCreateInfo* info,
+        const DownloadRequestHandle& request_handle,
+        DownloadManager* download_manager) = 0;
+  };
+
+  // Takes ownership of the factory.
+  // Passing in a NULL for |factory| will cause the default

[Randy Smith (Not in Mondays), 2011/12/07 20:57:41]

nit: "the" to "a", since we're talking about objects rather than classes.

[ahendrickson, 2011/12/07 21:11:17]

Done.

+  // |DownloadFileFactory| to be used.
+  DownloadFileManager(ResourceDispatcherHost* rdh,
+                      DownloadFileFactory* factory);
 
   // Called on shutdown on the UI thread.
   void Shutdown();
 
   // Called on UI thread to make DownloadFileManager start the download.
   void StartDownload(DownloadCreateInfo* info,
                      const DownloadRequestHandle& request_handle);
 
   // Handlers for notifications sent from the IO thread and run on the
   // FILE thread.
@@ skipping 75 matching lines @@
   typedef base::hash_map<DownloadId, DownloadFile*> DownloadFileMap;
 
   // A map of all in progress downloads.  It owns the download files.
   DownloadFileMap downloads_;
 
   // Schedule periodic updates of the download progress. This timer
   // is controlled from the FILE thread, and posts updates to the UI thread.
   base::RepeatingTimer<DownloadFileManager> update_timer_;
 
   ResourceDispatcherHost* resource_dispatcher_host_;
+  scoped_ptr<DownloadFileFactory> download_file_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(DownloadFileManager);
 };
 
 #endif  // CONTENT_BROWSER_DOWNLOAD_DOWNLOAD_FILE_MANAGER_H_