ppapi/native_client/src/shared/ppapi_proxy/plugin_ppb_file_io.cc - Issue 8770023: Break FileIO and URLLoader tests down into individual cases.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ppapi/native_client/src/shared/ppapi_proxy/plugin_ppb_file_io.cc

Issue 8770023: Break FileIO and URLLoader tests down into individual cases. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: '' Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ppapi/native_client/src/shared/ppapi_proxy/plugin_ppb_file_io.cc

===================================================================

--- ppapi/native_client/src/shared/ppapi_proxy/plugin_ppb_file_io.cc (revision 112536)

+++ ppapi/native_client/src/shared/ppapi_proxy/plugin_ppb_file_io.cc (working copy)

@@ -159,8 +159,8 @@

offset, bytes_to_read);

if (bytes_to_read < 0)

- bytes_to_read = 0;

- nacl_abi_size_t buffer_size = bytes_to_read;

+ return PP_ERROR_FAILED;

bbudge 2011/12/06 22:48:15 Could have been PP_ERROR_BADARGUMENT but I would h

+ nacl_abi_size_t buffer_size = static_cast<nacl_abi_size_t>(bytes_to_read);

int32_t callback_id =

CompletionCallbackTable::Get()->AddCallback(callback, buffer);

@@ -196,7 +196,7 @@

offset, bytes_to_write);

if (bytes_to_write < 0)

- bytes_to_write = 0;

+ return PP_ERROR_FAILED;

bbudge 2011/12/06 22:48:15 ditto

nacl_abi_size_t buffer_size = static_cast<nacl_abi_size_t>(bytes_to_write);

int32_t callback_id =

« no previous file with comments | « chrome/test/ui/ppapi_uitest.cc ('k') | ppapi/tests/test_url_loader.h » ('j') | no next file with comments »