Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 8770019: Cleanup for the virtual driver setup. (Closed)

Created:
9 years ago by Albert Bodenhamer
Modified:
9 years ago
Reviewers:
Scott Byer
CC:
chromium-reviews
Visibility:
Public.

Description

Remove extranious fonts from the ppd file Properly handle dependencies for installing the ppd Register for uninstall BUG=106094 TEST=Copy port monitor dlls, virtual_driver_setup.exe, and gcp-driver.ppd into a single folder and launch the setup as admin. The driver should be installed. Run it again with --uninstall (or choose the cloud print driver in add/remove programs) and the driver should be uninstalled and the containing folder removed. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113889

Patch Set 1 #

Patch Set 2 : Add missing file #

Patch Set 3 : Cleanup #

Patch Set 4 : Inner installer working #

Patch Set 5 : Path independence #

Patch Set 6 : Restore logs #

Patch Set 7 : Cleanup #

Patch Set 8 : More cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+182 lines, -97 lines) Patch
M cloud_print/virtual_driver/GCP-driver.ppd View 2 chunks +1 line, -24 lines 0 comments Download
M cloud_print/virtual_driver/win/install/setup.cc View 1 2 3 4 5 6 7 12 chunks +176 lines, -71 lines 0 comments Download
M cloud_print/virtual_driver/win/install/virtual_driver_install.gyp View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M cloud_print/virtual_driver/win/virtual_driver_common_resources.rc View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Albert Bodenhamer
9 years ago (2011-12-07 00:20:51 UTC) #1
Scott Byer
lgtm
9 years ago (2011-12-09 00:31:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abodenha@chromium.org/8770019/12005
9 years ago (2011-12-09 17:15:37 UTC) #3
commit-bot: I haz the power
Try job failure for 8770019-12005 (retry) on mac_rel for step "browser_tests". It's a second try, ...
9 years ago (2011-12-09 19:07:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abodenha@chromium.org/8770019/12005
9 years ago (2011-12-09 21:57:02 UTC) #5
commit-bot: I haz the power
9 years ago (2011-12-10 00:12:58 UTC) #6
Change committed as 113889

Powered by Google App Engine
This is Rietveld 408576698