Issue 8770014: Remove ShouldUseGAIAProfileInfo suppression

Issue 8770014: Remove ShouldUseGAIAProfileInfo suppression (Closed)

Created:
9 years ago by sail

Modified:
9 years ago

Reviewers:
cbentzel, Emmanuel Saint-loubert-Bié

CC:
chromium-reviews, Timur Iskhodzhanov, Alexander Potapenko, pam+watch_chromium.org, stuartmorgan+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove ShouldUseGAIAProfileInfo suppression BUG=106010 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112504

Patch Set 1 #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -7 lines)			Patch
	M	tools/heapcheck/unit_tests.gtest-heapcheck.txt	View		1 chunk	+0 lines, -3 lines	0 comments	Download
	M	tools/valgrind/gtest_exclude/unit_tests.gtest.txt	View		1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

sail

Will submit once http://codereview.chromium.org/8758019/ is committed.

9 years ago (2011-12-01 19:47:35 UTC) #1

cbentzel

9 years ago (2011-12-01 19:49:42 UTC) #2

LGTM

On Thu, Dec 1, 2011 at 2:47 PM, <sail@chromium.org> wrote:

> Reviewers: cbentzel, Emmanuel Saint-loubert,
>
> Message:
> Will submit once
http://codereview.chromium.**org/8758019/<http://codereview.chromium.org/8758...
committed.
>
> Description:
> Remove ShouldUseGAIAProfileInfo suppression
>
> BUG=106010
> TEST=
>
>
> Please review this at
http://codereview.chromium.**org/8770014/<http://codereview.chromium.org/8770...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>  M tools/heapcheck/unit_tests.**gtest-heapcheck.txt
>  M tools/valgrind/gtest_exclude/**unit_tests.gtest.txt
>
>
> Index: tools/heapcheck/unit_tests.**gtest-heapcheck.txt
> diff --git a/tools/heapcheck/unit_tests.**gtest-heapcheck.txt
> b/tools/heapcheck/unit_tests.**gtest-heapcheck.txt
> index bc1ba80502506d2c77086cf5af3309**11a608926b..**
> c36586988d4666fb2848efa8c1a86e**25012e5846 100644
> --- a/tools/heapcheck/unit_tests.**gtest-heapcheck.txt
> +++ b/tools/heapcheck/unit_tests.**gtest-heapcheck.txt
> @@ -27,6 +27,3 @@ GViewRequestInterceptorTest.**
> DoNotInterceptPdfWhenEnabled
>
>  # Crashing on CrOS. http://crbug.com/105335
>  BrowserMainTest.**WarmConnectionFieldTrial_**WarmestSocket
> -
> -# Fails under Heapcheck. http://crbug.com/106041
> -GAIAInfoUpdateServiceTest.**ShouldUseGAIAProfileInfo
> Index: tools/valgrind/gtest_exclude/**unit_tests.gtest.txt
> diff --git a/tools/valgrind/gtest_**exclude/unit_tests.gtest.txt
> b/tools/valgrind/gtest_**exclude/unit_tests.gtest.txt
> index a2b13894211c96ae95b8255a9cba4b**99489b4af5..**
> 20f0cbe0d062a767064f25a20846f1**6fa6fe9b4e 100644
> --- a/tools/valgrind/gtest_**exclude/unit_tests.gtest.txt
> +++ b/tools/valgrind/gtest_**exclude/unit_tests.gtest.txt
> @@ -23,7 +23,3 @@ SignedSettingsTest.**StorePolicyNoPolicyData
>
>  # Flaky and not very interesting under Valgrind http://crbug.com/93027
>  ProcessWatcherTest.**ImmediateTermination
> -
> -# Failing on CrOS, see http://crbug.com/106041
> -GAIAInfoUpdateServiceTest.**ShouldUseGAIAProfileInfo
> -
>
>
>

Expand Messages | Collapse Messages