Override status area window type for WebUI lock screen.

The screen locker window manager refuses to map most windows over the screen locker layer. This is for good reason to be safe about not allowing content to show up on top. To be able to see the status area window over the lock screen we can override the window type to be TYPE_POPUP. This must only be done for the lock screen as it does not allow focus to this window which is used on the login screen but not allowed on the lock screen due to the GTK grab.

BUG=105572
TEST=Lock screen and check if status area is visible.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113622

[flackr, 2011-12-07 21:04:52]

PTAL, thanks. I dug into the reason why this window was not being treated like
the popups that appear over the lock screen. Only override-redirect windows are
allowed. This property is set by GTK for windows of type GTK_POPUP. This seems
like a safe way of showing the status area window for the lock screen given that
it is not making the screen locker WM more permissive.

[Nikita (slow), 2011-12-08 14:13:12]

lgtm patchset #2.

Please run trybots.

http://codereview.chromium.org/8770012/diff/1/chrome/browser/chromeos/login/w...
File chrome/browser/chromeos/login/webui_screen_locker.cc (right):

http://codereview.chromium.org/8770012/diff/1/chrome/browser/chromeos/login/w...
chrome/browser/chromeos/login/webui_screen_locker.cc:479:
status_area_->SetPaintToLayer(true);
I see that you're adding status_area_ as a child view of the WebUIScreenLocker
and calling SetPaintToLayer(true) essentially make sure it is displayed over the
webui?

Did that approach even work?

[flackr, 2011-12-08 14:50:04]

http://codereview.chromium.org/8770012/diff/1/chrome/browser/chromeos/login/w...
File chrome/browser/chromeos/login/webui_screen_locker.cc (right):

http://codereview.chromium.org/8770012/diff/1/chrome/browser/chromeos/login/w...
chrome/browser/chromeos/login/webui_screen_locker.cc:479:
status_area_->SetPaintToLayer(true);
On 2011/12/08 14:13:12, Nikita Kostylev wrote:
> I see that you're adding status_area_ as a child view of the WebUIScreenLocker
> and calling SetPaintToLayer(true) essentially make sure it is displayed over
the
> webui?
> 
> Did that approach even work?

No, this didn't work.

[commit-bot: I haz the power, 2011-12-08 16:14:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/flackr@chromium.org/8770012/2001

[commit-bot: I haz the power, 2011-12-08 18:09:01]

Change committed as 113622