aura: Ask the WindowDelegate before a Window is Focus()ed.

aura: Ask the WindowDelegate before a Window is Focus()ed.

. In aura, before a window is focused, ask the delegate if it can be focused.
. Make a popup RWHVA non-focusable.

This is to prevent the focus from moving from the main web-page to the combobox (which causes the combobox to get destroyed). This fixes an issue where comboboxes in the login screen could not be used properly.

BUG=105786
TEST=manually

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112909

[sadrul, 2011-12-01 21:48:03]

Made some changes:
. In aura, before a window is focused, ask the delegate if it can be focused.
. Make a popup RWHVA non-focusable.

This is to prevent the focus from moving from the main web-page to the combobox
(which causes the combobox to get destroyed).

http://codereview.chromium.org/8770011/diff/3001/ui/aura/window_delegate.h
File ui/aura/window_delegate.h (right):

http://codereview.chromium.org/8770011/diff/3001/ui/aura/window_delegate.h#ne...
ui/aura/window_delegate.h:62: virtual bool CanFocus() { return true; }
This probably should be pure virtual?

[Ben Goodger (Google), 2011-12-01 22:16:31]

http://codereview.chromium.org/8770011/diff/3001/ui/aura/window_delegate.h
File ui/aura/window_delegate.h (right):

http://codereview.chromium.org/8770011/diff/3001/ui/aura/window_delegate.h#ne...
ui/aura/window_delegate.h:62: virtual bool CanFocus() { return true; }
On 2011/12/01 21:48:03, sadrul wrote:
> This probably should be pure virtual?

Yes it should. In general, when you are adding the first non-pure virtual method
to an interface, ur doin' it rong.

[sadrul, 2011-12-01 22:18:23]

http://codereview.chromium.org/8770011/diff/3001/ui/aura/window_delegate.h
File ui/aura/window_delegate.h (right):

http://codereview.chromium.org/8770011/diff/3001/ui/aura/window_delegate.h#ne...
ui/aura/window_delegate.h:62: virtual bool CanFocus() { return true; }
On 2011/12/01 22:16:31, Ben Goodger (Google) wrote:
> On 2011/12/01 21:48:03, sadrul wrote:
> > This probably should be pure virtual?
> 
> Yes it should. In general, when you are adding the first non-pure virtual
method
> to an interface, ur doin' it rong.

Yes :) I wanted to confirm the approach looks sane. I will update the patch to
add purity

[sadrul, 2011-12-02 02:25:54]

http://codereview.chromium.org/8770011/diff/3001/ui/aura/window_delegate.h
File ui/aura/window_delegate.h (right):

http://codereview.chromium.org/8770011/diff/3001/ui/aura/window_delegate.h#ne...
ui/aura/window_delegate.h:62: virtual bool CanFocus() { return true; }
On 2011/12/01 22:18:23, sadrul wrote:
> On 2011/12/01 22:16:31, Ben Goodger (Google) wrote:
> > On 2011/12/01 21:48:03, sadrul wrote:
> > > This probably should be pure virtual?
> > 
> > Yes it should. In general, when you are adding the first non-pure virtual
> method
> > to an interface, ur doin' it rong.
> 
> Yes :) I wanted to confirm the approach looks sane. I will update the patch to
> add purity

Done.

[sadrul, 2011-12-03 00:41:58]

ping!

[Ben Goodger (Google), 2011-12-03 00:42:46]

lgtm