Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 8770010: views: Move views.gyp to ui/views/. (Closed)

Created:
9 years ago by tfarina
Modified:
9 years ago
CC:
chromium-reviews, sadrul, ben+watch_chromium.org, dhollowa+watch_chromium.org, jam, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, tfarina
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebase #

Patch Set 4 : fix typos in views.gyp #

Patch Set 5 : fix the path to views_examples.exe.manifest #

Patch Set 6 : rebase to get the latest changes to views.gyp #

Patch Set 7 : fix aura build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+781 lines, -804 lines) Patch
M build/all.gyp View 6 chunks +7 lines, -7 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 5 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/chrome_dll.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 4 5 10 chunks +10 lines, -10 lines 0 comments Download
M content/content_browser.gypi View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/aura_shell/aura_shell.gyp View 1 2 3 4 5 4 chunks +6 lines, -6 lines 0 comments Download
M ui/views/DEPS View 1 chunk +6 lines, -2 lines 0 comments Download
A + ui/views/PRESUBMIT.py View 1 chunk +1 line, -1 line 0 comments Download
A ui/views/views.gyp View 1 2 3 4 5 6 1 chunk +745 lines, -0 lines 0 comments Download
D views/DEPS View 1 chunk +0 lines, -10 lines 0 comments Download
D views/OWNERS View 1 chunk +0 lines, -4 lines 0 comments Download
D views/PRESUBMIT.py View 1 chunk +0 lines, -12 lines 0 comments Download
D views/views.gyp View 1 2 3 4 5 1 chunk +0 lines, -746 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
tfarina
Forgot to send the email :(
9 years ago (2011-12-01 20:34:15 UTC) #1
Ben Goodger (Google)
9 years ago (2011-12-01 21:37:01 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698