Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Unified Diff: media/audio/win/wavein_input_win.cc

Issue 8770005: Adds input device selection on Windows. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Rebased Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/audio/win/wavein_input_win.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/audio/win/wavein_input_win.cc
===================================================================
--- media/audio/win/wavein_input_win.cc (revision 112958)
+++ media/audio/win/wavein_input_win.cc (working copy)
@@ -12,11 +12,14 @@
#include "media/audio/audio_io.h"
#include "media/audio/audio_util.h"
#include "media/audio/win/audio_manager_win.h"
+#include "media/audio/win/device_enumeration_win.h"
namespace {
const int kStopInputStreamCallbackTimeout = 3000; // Three seconds.
}
+using media::AudioDeviceNames;
+
// Our sound buffers are allocated once and kept in a linked list using the
// the WAVEHDR::dwUser variable. The last buffer points to the first buffer.
static WAVEHDR* GetNextBuffer(WAVEHDR* current) {
@@ -25,7 +28,7 @@
PCMWaveInAudioInputStream::PCMWaveInAudioInputStream(
AudioManagerWin* manager, const AudioParameters& params, int num_buffers,
- UINT device_id)
+ const std::string& device_id)
: state_(kStateEmpty),
manager_(manager),
device_id_(device_id),
@@ -58,10 +61,20 @@
return false;
if (num_buffers_ < 2 || num_buffers_ > 10)
return false;
- MMRESULT result = ::waveInOpen(&wavein_, device_id_, &format_,
- reinterpret_cast<DWORD_PTR>(WaveCallback),
- reinterpret_cast<DWORD_PTR>(this),
- CALLBACK_FUNCTION);
+
+ // Convert the stored device id string into an unsigned integer
+ // corresponding to the selected device.
+ UINT device_id = WAVE_MAPPER;
+ if (!GetDeviceId(&device_id)) {
+ return false;
+ }
+
+ // Open the specified input device for recording.
+ MMRESULT result = MMSYSERR_NOERROR;
+ result = ::waveInOpen(&wavein_, device_id, &format_,
+ reinterpret_cast<DWORD_PTR>(WaveCallback),
+ reinterpret_cast<DWORD_PTR>(this),
+ CALLBACK_FUNCTION);
if (result != MMSYSERR_NOERROR)
return false;
@@ -185,6 +198,41 @@
HandleError(res);
}
+bool PCMWaveInAudioInputStream::GetDeviceId(UINT* device_index) {
+ // Deliver the default input device id (WAVE_MAPPER) if the default
+ // device has been selected.
+ if (device_id_ == AudioManagerBase::kDefaultDeviceId) {
+ *device_index = WAVE_MAPPER;
+ return true;
+ }
+
+ // Get list of all available and active devices.
+ AudioDeviceNames device_names;
+ if (!GetInputDeviceNamesWinXP(&device_names))
+ return false;
+
+ if (device_names.empty())
+ return false;
+
+ // Search the full list of devices and compare with the specified
+ // device id which was specified in the constructor. Stop comparing
+ // when a match is found and return the corresponding index.
+ UINT index = 0;
+ bool found_device = false;
+ AudioDeviceNames::const_iterator it = device_names.begin();
+ while (it != device_names.end()) {
+ if (it->unique_id.compare(device_id_) == 0) {
+ *device_index = index;
+ found_device = true;
+ break;
+ }
+ ++index;
+ ++it;
+ }
+
+ return found_device;
+}
+
// Windows calls us back in this function when some events happen. Most notably
// when it has an audio buffer with recorded data.
void PCMWaveInAudioInputStream::WaveCallback(HWAVEIN hwi, UINT msg,
« no previous file with comments | « media/audio/win/wavein_input_win.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698