Remove stuff in TokenService that is not needed anymore (due to OAuth based approach):

Remove stuff in TokenService that is not needed anymore (due to OAuth based approach):
- Remove the CWS service and token generation for that.
- Remove StartFetchingMissingTokens method
- Remove unit test for removed code.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113058

[Munjal (Google), 2011-12-05 01:56:27]

Hey Roger, Zel and Tim,

Can one of ou please reviews this? It would be nice ot commit this before code
freeze.

[zel, 2011-12-05 22:04:15]

LGTM

http://codereview.chromium.org/8769053/diff/1/chrome/browser/net/gaia/token_s...
File chrome/browser/net/gaia/token_service.h (right):

http://codereview.chromium.org/8769053/diff/1/chrome/browser/net/gaia/token_s...
chrome/browser/net/gaia/token_service.h:248: static const int kNumServices = 6;
GaiaConstants::kPicasaService got removed as well in another CL -
http://codereview.chromium.org/8742008/ - you will have to resolve this conflict
before landing

[Munjal (Google), 2011-12-05 22:12:23]

http://codereview.chromium.org/8769053/diff/1/chrome/browser/net/gaia/token_s...
File chrome/browser/net/gaia/token_service.h (right):

http://codereview.chromium.org/8769053/diff/1/chrome/browser/net/gaia/token_s...
chrome/browser/net/gaia/token_service.h:248: static const int kNumServices = 6;
On 2011/12/05 22:04:16, zel wrote:
> GaiaConstants::kPicasaService got removed as well in another CL -
> http://codereview.chromium.org/8742008/ - you will have to resolve this
conflict
> before landing

Yep, I have that in mind. In fact, I was wondering if the code will be
auto-merged since both I and Sailesh set this value to 6 (ahd hence have an
identical line). If so, I should be very careful in editing file manually even
though not marked conflicted.

Thanks for pointing this out.

[Rick Campbell, 2011-12-06 15:56:20]

lgtm