Issue 8769049: Fix MessagePumpX::ProcessXEvent checking of WillProcessXEvent return value.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8769049: Fix MessagePumpX::ProcessXEvent checking of WillProcessXEvent return value. (Closed)

Created:
9 years ago by David Li

Modified:
9 years ago

Reviewers:
Nico, sadrul

CC:
chromium-reviews, sadrul, brettw-cc_chromium.org, oshima

Base URL:
http://git.chromium.org/git/chromium.git@trunk

Visibility:
Public.

More Reviews

Description

Fix MessagePumpX::ProcessXEvent checking of WillProcessXEvent return value. WillProcessXEvent returns false to indicate continue normal dispatch. The check worked because EVENT_CONTINUE happens to be 0. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112872

Patch Set 1 #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	base/message_pump_x.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davidxli@chromium.org/8769049/1

9 years ago (2011-12-03 03:44:30 UTC) #5

Change committed as 112872

Expand Messages | Collapse Messages