Issue 8769035: Fix ChromeOS clang build after original change was reverted.

Issue 8769035: Fix ChromeOS clang build after original change was reverted. (Closed)

Created:
9 years ago by Joao da Silva

Modified:
9 years ago

Reviewers:
mal, Simon Que

CC:
chromium-reviews, robertshield, kkania, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix ChromeOS clang build after original change was reverted. TBR=sque@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112699

Patch Set 1 #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -10 lines)			Patch
	M	chrome/browser/automation/testing_automation_provider.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
	M	chrome/browser/automation/testing_automation_provider_chromeos.cc	View		1 chunk	+0 lines, -8 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/8769035/1

9 years ago (2011-12-02 13:01:34 UTC) #1

mal

9 years ago (2011-12-02 17:27:46 UTC) #3

Chromium OS (x86) is broken by this patch. vmtests:

suite_Smoke/desktopui_ScreenLocker             [  FAILED  ]
suite_Smoke/desktopui_ScreenLocker               ERROR: Timed out waiting for
login prompt
suite_Smoke/desktopui_ScreenLocker               12/02 08:29:34
ERROR|site_utils:0077| Timed out waiting for login prompt
suite_Smoke/desktopui_ScreenLocker               12/02 08:31:05
ERROR|site_utils:0077| Timed out waiting for login prompt
suite_Smoke/desktopui_ScreenLocker               12/02 08:31:05 ERROR|     
test:0430| Ignoring exception during cleanup() phase:
suite_Smoke/desktopui_ScreenLocker               12/02 08:31:05 ERROR|
traceback:0013| Traceback (most recent call last):
suite_Smoke/desktopui_ScreenLocker               12/02 08:31:05 ERROR|
traceback:0013|   File "/usr/local/autotest/common_lib/test.py", line 428, in
_exec
suite_Smoke/desktopui_ScreenLocker               12/02 08:31:05 ERROR|
traceback:0013|     _cherry_pick_call(self.cleanup, *args, **dargs)
suite_Smoke/desktopui_ScreenLocker               12/02 08:31:05 ERROR|
traceback:0013|   File "/usr/local/autotest/common_lib/test.py", line 535, in
_cherry_pick_call
suite_Smoke/desktopui_ScreenLocker               12/02 08:31:05 ERROR|
traceback:0013|     return func(*p_args, **p_dargs)
suite_Smoke/desktopui_ScreenLocker               12/02 08:31:05 ERROR|
traceback:0013|   File "/usr/local/autotest/cros/cros_ui_test.py", line 444, in
cleanup
suite_Smoke/desktopui_ScreenLocker               12/02 08:31:05 ERROR|
traceback:0013|     pyauto_test.PyAutoTest.cleanup(self)
suite_Smoke/desktopui_ScreenLocker               12/02 08:31:05 ERROR|
traceback:0013|   File "/usr/local/autotest/cros/pyauto_test.py", line 178, in
cleanup
suite_Smoke/desktopui_ScreenLocker               12/02 08:31:05 ERROR|
traceback:0013|     cros_ui.restart()
suite_Smoke/desktopui_ScreenLocker               12/02 08:31:05 ERROR|
traceback:0013|   File "/usr/local/autotest/cros/cros_ui.py", line 148, in
restart
suite_Smoke/desktopui_ScreenLocker               12/02 08:31:05 ERROR|
traceback:0013|     _wait_for_login_prompt()
suite_Smoke/desktopui_ScreenLocker               12/02 08:31:05 ERROR|
traceback:0013|   File "/usr/local/autotest/cros/cros_ui.py", line 104, in
_wait_for_login_prompt
suite_Smoke/desktopui_ScreenLocker               12/02 08:31:05 ERROR|
traceback:0013|     timeout=timeout)
suite_Smoke/desktopui_ScreenLocker               12/02 08:31:05 ERROR|
traceback:0013|   File "/usr/local/autotest/bin/site_utils.py", line 78, in
poll_for_condition
suite_Smoke/desktopui_ScreenLocker               12/02 08:31:05 ERROR|
traceback:0013|     raise exception
suite_Smoke/desktopui_ScreenLocker               12/02 08:31:05 ERROR|
traceback:0013| TimeoutError: Timed out waiting for login prompt
suite_Smoke/desktopui_ScreenLocker               12/02 08:31:05 ERROR|     
test:0433| Now raising the earlier <class
'autotest_lib.client.bin.site_utils.TimeoutError'> error
suite_Smoke/desktopui_UrlFetch.not-live        [  FAILED  ]

Expand Messages | Collapse Messages