Issue 8769028: Disable broken Panel tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8769028: Disable broken Panel tests (Closed)

Created:
9 years ago by dcheng

Modified:
9 years ago

Reviewers:
jianli

CC:
chromium-reviews, jennb, prasadt, jianli, Dmitry Titov, dcheng, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Disable broken Panel tests BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112587

Patch Set 1 #

Patch Set 2 : . #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	chrome/browser/ui/panels/panel_browser_view_browsertest.cc	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
	M	chrome/browser/ui/panels/panel_browsertest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jianli

9 years ago (2011-12-02 01:05:07 UTC) #2

LGTM.

On Thu, Dec 1, 2011 at 5:02 PM, <dcheng@chromium.org> wrote:

> Reviewers: jianli,
>
> Message:
> Sanity check before I land.
>
> Description:
> Disable PanelAndNotificationTest.**NoOverlapping
>
> BUG=none
> TEST=none
>
>
> Please review this at
http://codereview.chromium.**org/8769028/<http://codereview.chromium.org/8769...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>  M chrome/browser/ui/panels/**panel_browsertest.cc
>
>
> Index: chrome/browser/ui/panels/**panel_browsertest.cc
> diff --git a/chrome/browser/ui/panels/**panel_browsertest.cc
> b/chrome/browser/ui/panels/**panel_browsertest.cc
> index 6413356e8300aecb7f881db68a3ddb**dc70b85c38..**
> 27907f9dfd80960250110c2b6bfc02**cac011f73d 100644
> --- a/chrome/browser/ui/panels/**panel_browsertest.cc
> +++ b/chrome/browser/ui/panels/**panel_browsertest.cc
> @@ -1854,7 +1854,7 @@ class PanelAndNotificationTest : public
> PanelBrowserTest {
>   scoped_ptr<**DesktopNotificationService> service_;
>  };
>
> -IN_PROC_BROWSER_TEST_F(**PanelAndNotificationTest, NoOverlapping) {
> +IN_PROC_BROWSER_TEST_F(**PanelAndNotificationTest,
> DISABLED_NoOverlapping) {
>   const int kPanelWidth = 200;
>   const int kShortPanelHeight = 150;
>   const int kTallPanelHeight = 200;
>
>
>

Expand Messages | Collapse Messages