Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: build/android/android_commands.py

Issue 8769020: Android bot changes for robustness, profiling, and debugging. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/android/buildbot.sh » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/android_commands.py
diff --git a/build/android/android_commands.py b/build/android/android_commands.py
index af1a6b8cd4e8ea22deaee775d8172643d53340eb..007d040229bd7efe3d9477080abb2728b8aeb08f 100755
--- a/build/android/android_commands.py
+++ b/build/android/android_commands.py
@@ -423,7 +423,11 @@ class AndroidCommands(object):
# 60 seconds which isn't sufficient for a lot of users of this method.
push_command = 'push %s %s' % (local_path, device_path)
logging.info('>>> $' + push_command)
- self._adb.SendCommand(push_command, timeout_time=30*60)
+ output = self._adb.SendCommand(push_command, timeout_time=30*60)
+ # Success looks like this: "3035 KB/s (12512056 bytes in 4.025s)"
+ # Errors look like this: "failed to copy ... "
+ if not re.search('^[0-9]', output):
+ logging.critical('PUSH FAILED: ' + output)
def GetFileContents(self, filename):
"""Gets contents from the file specified by |filename|."""
« no previous file with comments | « no previous file | build/android/buildbot.sh » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698